58716[BUGFIX] Hide translated pages the BE-User has no access to
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1822
-
Ursula Klinger uploaded patch set 1 10/26/18, 14:15
-
TYPO3com voted on patch set 1 V +1 10/26/18, 14:35 Completed build in 18m 48s on Fri, 26 Oct, 04:35 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29606
-
Jürgen Heym commented on patch set 1 V +1 CR +1 10/27/18, 10:03
Verified on IntroPackage ... -
Ursula Klinger uploaded patch set 2 10/27/18, 10:13
-
TYPO3com voted on patch set 2 V +1 10/27/18, 10:36 Completed build in 18m 29s on Sat, 27 Oct, 12:36 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29645
-
Jürgen Heym voted on patch set 2 V +1 CR +1 10/27/18, 10:42
-
Jasmina Ließmann commented on patch set 2 V -1 10/27/18, 12:54
The patch has side effects. If the page was translated in 'connected mode' no content elements are shown at all. For 'free mode' it works. -
Jasmina Ließmann commented on patch set 2 10/27/18, 14:04
Just thinking about if the editor can only access the default language and not translations: When the editor deletes the page in default language he receives the error message "Attempt to delete page which has prohibited localizations." and the page can not be deleted. Maybe we can give the editor an indication that translations for the pages exists even if he can't see them? Otherwise it might be difficult for him to understand the behavior. -
Jasmina Ließmann commented on patch set 2 10/27/18, 14:34
Suggestion 1: Hint in the module "Page" (and maybe also in "List") that translations exist for this page. This hint could be permanent or only if the editor does not have access to min. one of the translations. This could be represented like the hint displayed when browsing the module "List" and no records exist on a page (.typo3-message > .alert-info ). Suggestion 2: Open a modal window with option to delete or keep the translations (like the modal window for translating content elements). -
Ursula Klinger uploaded patch set 3 10/27/18, 16:54
-
Jasmina Ließmann commented on patch set 3 V +1 10/27/18, 17:06
The translated content elements are visible in list module now. Editing the translated content elements is not possible, but this was already an error before (see https://forge.typo3.org/issues/86771). -
TYPO3com voted on patch set 3 V +1 10/27/18, 17:07 Completed build in 13m 21s on Sat, 27 Oct, 07:07 PM Test Summary: 37837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29688
-
Joerg Kummer commented on patch set 3 10/28/18, 12:08
Pending patch #57287 also creates class file \TYPO3\CMS\Database\Query\Restriction\LanguageAccessRestriction.php -
Susi Moog rebased onto patch set 4 12/06/19, 21:30
-
TYPO3com voted on patch set 4 V +1 12/06/19, 21:39 Completed build in 08m 49s on Fri, 6 Dec, 09:39 PM Test Summary: 68708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39227
-
Henning Liebe voted on patch set 4 CR +1 01/14/20, 11:31
-
Felix P. voted on patch set 4 CR +1 01/14/20, 12:02
-
Sascha Rademacher voted on patch set 4 V +1 CR +1 01/14/20, 13:01
-
Tymoteusz Motylewski commented on patch set 4 01/14/20, 20:38
Is this bug only present in master or should also be backported to v9.5? -
Steffen Frese voted on patch set 4 V +1 CR +1 01/15/20, 09:01
-
Georg Ringer commented on patch set 4 03/10/20, 05:00
should be solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/63232, can you check? -
Richard Haeser abandoned the change 01/31/21, 09:35
Thanks. Meanwhile this is fixed by the patch Georg mentioned