Review main Merged

58718[TASK] Move page fields to new tab 'social media'

Jasmina Ließmann CR +2 V +2 Easy +13 −2 updated 10/27/18, 20:31

Commit message

Move fields for open graph and twitter card to a new tab 'social media'

Review

  • Code review CR +2
    • Benni Mack +2
    • Jürgen Heym +1
  • Verified V +2
    • Benni Mack +2
    • Jürgen Heym +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Jasmina Ließmann uploaded patch set 1 10/26/18, 15:03

  2. Marc Hirdes voted on patch set 1 CR +1 10/26/18, 15:09

  3. TYPO3com voted on patch set 1 V +1 10/26/18, 15:29 Completed build in 21m 50s on Fri, 26 Oct, 05:29 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29615

  4. Richard Haeser commented on patch set 1 10/26/18, 15:33

    I think we have a duplicate now: https://review.typo3.org/#/c/58600/
  5. Richard Haeser voted on patch set 1 CR +1 10/26/18, 15:34

  6. Richard Haeser voted on patch set 1 V +1 10/26/18, 15:35

  7. Richard Haeser commented on patch set 1 CR 0 10/26/18, 15:49

    pages.php:205

    This line is not needed because it is already executed on line 193
  8. Jasmina Ließmann uploaded patch set 2 10/27/18, 09:16

  9. TYPO3com voted on patch set 2 V +1 10/27/18, 09:30 Completed build in 13m 41s on Sat, 27 Oct, 11:30 AM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29636

  10. Jürgen Heym voted on patch set 2 V +1 CR +1 10/27/18, 13:54

  11. Daniel Goerz commented on patch set 2 10/27/18, 14:53

    THis is done in this patch as well: https://review.typo3.org/#/c/58600/
  12. Benni Mack voted on patch set 2 V +2 CR +2 10/27/18, 20:31

  13. Benni Mack merged patch set 3 10/27/18, 20:31