Review main Merged

58722[BUGFIX] Always use default language for uniqueInSite

Benni Mack CR +2 V +2 Normal +53 −9 updated 10/29/18, 09:58

Commit message

SlugHelper fetches records of the same language, and takes the
pageId of the _current_ language record (uid), which is wrong.
For records, it must be 'pid', for pages it must be 'uid', but for
translated pages it must be 'pages.l10n_parent'.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Oliver Hader +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Benni Mack uploaded patch set 1 10/26/18, 16:53

  2. TYPO3com voted on patch set 1 V +1 10/26/18, 17:04 Completed build in 11m 02s on Fri, 26 Oct, 07:04 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29623

  3. Susi Moog voted on patch set 1 V +1 CR +1 10/27/18, 10:09

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/27/18, 20:41

  5. Anja Leichsenring voted on patch set 1 V 0 CR 0 10/27/18, 20:45

  6. Oliver Hader commented on patch set 1 10/27/18, 20:45

    Is this still required after https://review.typo3.org/#/c/58229/ was merged?
  7. Anja Leichsenring commented on patch set 1 V -1 CR -1 10/27/18, 20:47

    > Patch Set 1: > > Is this still required after https://review.typo3.org/#/c/58229/ was merged? rebase will fail due to missing $languageId property. Please have a look.
  8. Oliver Hader commented on patch set 1 10/27/18, 20:56

    DataHandler.php:1995

    Handled by RecordState::resolveAggregateNodeIdentifier() now

    SlugHelper.php:269

    Probably still required, will investigate
  9. Oliver Hader uploaded patch set 2 10/27/18, 21:36

  10. TYPO3com voted on patch set 2 V -1 10/27/18, 21:48 Completed build in 11m 43s on Sat, 27 Oct, 11:48 PM Test Summary: 6 of 38203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29711

  11. Oliver Hader rebased onto patch set 3 10/28/18, 11:22

  12. TYPO3com voted on patch set 3 V -1 10/28/18, 11:34 Completed build in 11m 37s on Sun, 28 Oct, 12:34 PM Test Summary: 6 of 38203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29735

  13. Oliver Hader uploaded patch set 4 10/28/18, 18:22

  14. Oliver Hader voted on patch set 4 V +1 CR +1 10/28/18, 18:30

  15. TYPO3com voted on patch set 4 V +1 10/28/18, 18:31 Completed build in 08m 47s on Sun, 28 Oct, 07:31 PM Test Summary: 38167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29794

  16. Wouter Wolters voted on patch set 4 CR +1 10/29/18, 09:25

  17. Susi Moog voted on patch set 4 V +1 CR +1 10/29/18, 09:57

  18. Benni Mack voted on patch set 4 V +2 CR +2 10/29/18, 09:58

  19. Benni Mack merged patch set 5 10/29/18, 09:58