Review main Merged

58730[BUGFIX] Show original error in ReflectionService exception

Susi Moog CR +2 V +2 Normal +147 −5 updated 10/27/18, 19:18

Commit message

Instead of displaying a custom error message, let the original
exception message be part of the ReflectionException to differentiate
if the original class or any of the type hints has a problem.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Sybille Peters +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Sybille Peters +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1521

  1. Susi Moog uploaded patch set 1 10/27/18, 11:03

  2. Susi Moog uploaded patch set 2 10/27/18, 11:12

  3. TYPO3com voted on patch set 1 V +1 10/27/18, 11:18 Completed build in 14m 16s on Sat, 27 Oct, 01:18 PM Test Summary: 37821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29650

  4. TYPO3com voted on patch set 2 V -1 10/27/18, 11:32 Completed build in 17m 14s on Sat, 27 Oct, 01:32 PM Test Summary: 5 of 38185 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29654

  5. Susi Moog uploaded patch set 3 10/27/18, 12:03

  6. TYPO3com voted on patch set 3 V -1 10/27/18, 12:22 Completed build in 16m 20s on Sat, 27 Oct, 02:22 PM Test Summary: 4 of 38185 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29664

  7. Anja Leichsenring uploaded patch set 4 10/27/18, 13:34

  8. TYPO3com voted on patch set 4 V -1 10/27/18, 13:34 Completed build in 10s on Sat, 27 Oct, 03:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29667

  9. Anja Leichsenring uploaded patch set 5 10/27/18, 13:37

  10. Anja Leichsenring uploaded patch set 6 10/27/18, 13:43

  11. TYPO3com voted on patch set 5 V -1 10/27/18, 13:52 Completed build in 15m 07s on Sat, 27 Oct, 03:52 PM Test Summary: 1 of 38200 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29669

  12. Susi Moog abandoned the change 10/27/18, 13:56

    not wanted.
  13. Susi Moog restored the change 10/27/18, 13:56

  14. Susi Moog commented on patch set 6 10/27/18, 13:56

    wrong patch.
  15. TYPO3com voted on patch set 6 V +1 10/27/18, 14:04 Completed build in 19m 07s on Sat, 27 Oct, 04:04 PM Test Summary: 37840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29672

  16. Susi Moog voted on patch set 6 V +1 CR +1 10/27/18, 15:03

  17. Wouter Wolters voted on patch set 6 CR +1 10/27/18, 16:12

  18. Sybille Peters voted on patch set 6 V +1 10/27/18, 17:10

  19. Sybille Peters voted on patch set 6 CR +1 10/27/18, 18:18

  20. Anja Leichsenring voted on patch set 6 V +2 CR +2 10/27/18, 19:18

  21. Anja Leichsenring merged patch set 7 10/27/18, 19:18