Review TYPO3_8-7 Merged

58736[BUGFIX] EvaluteDisplayCondition should throw proper error message

Jigal van Hemert CR +2 V +2 Easy +23 −1 updated 10/27/18, 19:53

Commit message

When an extension author writes a display condition in TCA and
by incident uses a wrong format for the displayCondition (see ticket)
the strtoupper fails due to the lack of an associative array
because it's a numeric-key array.

An additional check fixes the issue.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Jigal van Hemert +1
  • Verified V +2
    • Anja Leichsenring +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Jigal van Hemert commented on patch set 1 10/27/18, 17:41

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/27/18, 17:50 Completed build in 09m 20s on Sat, 27 Oct, 07:50 PM Test Summary: 59636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3100

  3. Jigal van Hemert voted on patch set 1 V +1 CR +1 10/27/18, 17:52

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/27/18, 19:53

  5. Anja Leichsenring merged patch set 2 10/27/18, 19:53