Review TYPO3_8-7 Abandoned

58741[BUGFIX] Show original error in ReflectionService exception

Anja Leichsenring CR 0 V 0 Normal +49 −22 updated 10/28/18, 16:06

Commit message

Instead of displaying a custom error message, let the original
exception message be part of the ReflectionException to differentiate
if the original class or any of the type hints has a problem.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 46

  1. Anja Leichsenring uploaded patch set 1 10/27/18, 19:47

  2. TYPO3com voted on patch set 1 V -1 10/27/18, 19:47 Completed build in 09s on Sat, 27 Oct, 09:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3103

  3. Anja Leichsenring uploaded patch set 2 10/27/18, 19:49

  4. TYPO3com voted on patch set 2 V +1 10/27/18, 19:56 Completed build in 06m 49s on Sat, 27 Oct, 09:56 PM Test Summary: 59636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3104

  5. Joerg Kummer voted on patch set 2 V +1 CR +1 10/27/18, 21:48

  6. Anja Leichsenring abandoned the change 10/28/18, 16:06

    will not comply to the original patch, so abandon