Review main Merged

58758[TASK] Add unit tests for BackendUtiily::resolveFileReferences

Anja Leichsenring CR +2 V +2 Normal +91 −1 updated 10/28/18, 13:10

Commit message

This tests are a left over from a patch being abandoned.
Keeping them should not be wrong, they help identify notices
thrown, if nothing else.

Review

  • Code review CR +2
    • Benni Mack +2
    • Richard Haeser +1
  • Verified V +2
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Anja Leichsenring uploaded patch set 1 10/28/18, 12:31

  2. TYPO3com voted on patch set 1 V -1 10/28/18, 12:35 Completed build in 22s on Sun, 28 Oct, 01:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29747

  3. Richard Haeser commented on patch set 1 V -1 10/28/18, 12:37

    Unit-tests fails
  4. Anja Leichsenring uploaded patch set 2 10/28/18, 12:38

  5. Richard Haeser commented on patch set 2 V -1 10/28/18, 12:41

    Still the same error: 1) TYPO3\CMS\Backend\Tests\Unit\Utility\BackendUtilityTest::resolveFileReferencesReturnsEmptyResultForNoReferencesAvailable Undefined index: MM
  6. Anja Leichsenring uploaded patch set 3 10/28/18, 12:41

  7. Richard Haeser voted on patch set 3 V +1 CR +1 10/28/18, 12:43

  8. TYPO3com voted on patch set 2 V -1 10/28/18, 12:54 Completed build in 15m 48s on Sun, 28 Oct, 01:54 PM Test Summary: 3 of 35591 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29750

  9. TYPO3com voted on patch set 3 V +1 10/28/18, 13:08 Completed build in 22m 26s on Sun, 28 Oct, 02:08 PM Test Summary: 37864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29753

  10. Benni Mack voted on patch set 3 V +2 CR +2 10/28/18, 13:10

  11. Benni Mack merged patch set 4 10/28/18, 13:10