Review main Merged

58771[BUGFIX] Move SCSS instructions from modal to install.scss

Benni Mack CR +2 V +2 Easy +9 −7 updated 10/28/18, 18:29

Commit message

This change accidentally merged the code into the wrong file.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Wouter Wolters +1
  • Verified V +2
    • Oliver Hader +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 810

  1. Benni Mack uploaded patch set 1 10/28/18, 16:07

  2. TYPO3com voted on patch set 1 V +1 10/28/18, 16:23 Completed build in 15m 08s on Sun, 28 Oct, 05:22 PM Test Summary: 37891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29784

  3. Benni Mack commented on patch set 1 CR -1 10/28/18, 16:32

    needs a CSS compliation, does not work on my system
  4. Wouter Wolters commented on patch set 1 10/28/18, 16:32

    isn;t the new compiled version missing here?
  5. Daniel Goerz uploaded patch set 2 10/28/18, 16:43

  6. TYPO3com voted on patch set 2 V +1 10/28/18, 16:55 Completed build in 11m 15s on Sun, 28 Oct, 05:55 PM Test Summary: 38167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29790

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 10/28/18, 16:55

  8. Daniel Goerz commented on patch set 2 10/28/18, 16:57

    did not test, just compiled
  9. Oliver Hader voted on patch set 2 V +2 CR +2 10/28/18, 18:29

  10. Oliver Hader merged patch set 3 10/28/18, 18:29