Review main Merged

58774[TASK] Added default cropping ratio for social media images

Richard Haeser CR +2 V +2 Easy +47 −2 updated 10/29/18, 09:50

Commit message

Most of the social networks use the 1.91:1 aspect ratio for images that
belong to the page that is shared.

Now og:image and twitter:image will be rendering an image with a 1.91:1
ratio by default.

Review

  • Code review CR +2
    • Benni Mack +2
    • Riny van Tiggelen +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Riny van Tiggelen +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Richard Haeser uploaded patch set 1 10/29/18, 08:39

  2. TYPO3com voted on patch set 1 V +1 10/29/18, 08:50 Completed build in 11m 11s on Mon, 29 Oct, 09:50 AM Test Summary: 38167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29800

  3. Richard Haeser uploaded patch set 2 10/29/18, 08:51

  4. TYPO3com voted on patch set 2 V +1 10/29/18, 09:02 Completed build in 11m 13s on Mon, 29 Oct, 10:02 AM Test Summary: 38167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29801

  5. Riny van Tiggelen voted on patch set 2 V +1 CR +1 10/29/18, 09:06

  6. Susi Moog voted on patch set 2 CR +1 10/29/18, 09:48

  7. Benni Mack voted on patch set 2 V +2 CR +2 10/29/18, 09:50

  8. Benni Mack merged patch set 3 10/29/18, 09:50