Review TYPO3_8-7 Merged

58777[TASK] Use typo3/phar-stream-wrapper package

Oliver Hader CR +2 V +2 Hard +187 −596 updated 10/30/18, 08:06

Commit message

PharStreamWrapper has been released as standalone package under
the MIT license: https://github.com/TYPO3/phar-stream-wrapper

Stream invocation is handled by the new composer package, previous
classes PharStreamWrapper and PharStreamWrapperException have been
removed from the TYPO3 core but are still kept in class alias maps
for compatibility reasons. Since the standalone package is now
independent from TYPO3 constraints, the TYPO3 specific logic to
intercept Phar invocations has been moved to the new class
PharStreamWrapperInterceptor.

`composer require typo3/phar-stream-wrapper:^3.0.1`

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 2

Files 9

Review log 68

  1. Oliver Hader uploaded patch set 1 10/29/18, 11:24

  2. TYPO3com voted on patch set 1 V +1 10/29/18, 11:35 Completed build in 11m 18s on Mon, 29 Oct, 12:35 PM Test Summary: 60218 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3141

  3. Susi Moog voted on patch set 1 CR +1 10/29/18, 15:24

  4. Oliver Hader voted on patch set 1 CR -1 10/29/18, 16:36

  5. Oliver Hader commented on patch set 2 10/29/18, 18:06

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 10/29/18, 18:17 Completed build in 10m 36s on Mon, 29 Oct, 07:17 PM Test Summary: 60218 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3144

  7. Oliver Hader voted on patch set 2 V +2 CR +2 10/30/18, 08:04

  8. Oliver Hader merged patch set 3 10/30/18, 08:06