58778[TASK] Use typo3/phar-stream-wrapper package
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
- TYPO3com +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/Core/Bootstrap.php+11 −1
- typo3/sysext/core/Classes/IO/PharStreamWrapper.phpdeleted+0 −536
- typo3/sysext/core/Classes/IO/PharStreamWrapperException.phpdeleted+0 −19
- typo3/sysext/core/Classes/IO/PharStreamWrapperInterceptor.php4new+116 −0
- typo3/sysext/core/Classes/Migrations/Code/ClassAliasMap.phpnew+5 −0
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.phprenamed+10 −16
- composer.json+2 −1
- composer.lock+41 −1
Review log 68
-
Oliver Hader uploaded patch set 1 10/29/18, 12:03
-
TYPO3com voted on patch set 1 V +1 10/29/18, 12:08 Completed build in 05m 09s on Mon, 29 Oct, 01:08 PM Test Summary: 49502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1577
-
Benni Mack commented on patch set 1 CR -1 10/29/18, 16:13
PharStreamWrapperInterceptor.php:91not PHP 73 compatible. could you use "%" instead of "#"?PharStreamWrapperInterceptor.php:122we can get rid of this line. -
Oliver Hader commented on patch set 2 10/29/18, 18:03
Published edit on patch set 1. -
Oliver Hader commented on patch set 1 10/29/18, 18:05
PharStreamWrapperInterceptor.php:91ReplyOnly applies if used inside pattern, not as delimiter - http://php.net/manual/en/function.preg-quote.php -
TYPO3com voted on patch set 2 V +1 10/29/18, 18:10 Completed build in 06m 52s on Mon, 29 Oct, 07:10 PM Test Summary: 49502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1578
-
Oliver Hader voted on patch set 2 V +2 CR +2 10/30/18, 08:05
-
Oliver Hader merged patch set 3 10/30/18, 08:06
PharStreamWrapperInterceptor.php:38