Review TYPO3_7-6 Merged

58778[TASK] Use typo3/phar-stream-wrapper package

Oliver Hader CR +2 V +2 Hard +185 −574 updated 10/30/18, 08:06

Commit message

PharStreamWrapper has been released as standalone package under
the MIT license: https://github.com/TYPO3/phar-stream-wrapper

Stream invocation is handled by the new composer package, previous
classes PharStreamWrapper and PharStreamWrapperException have been
removed from the TYPO3 core but are still kept in class alias maps
for compatibility reasons. Since the standalone package is now
independent from TYPO3 constraints, the TYPO3 specific logic to
intercept Phar invocations has been moved to the new class
PharStreamWrapperInterceptor.

`composer require typo3/phar-stream-wrapper:^2.0.1`

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 2

Files 8

Review log 68

  1. Oliver Hader uploaded patch set 1 10/29/18, 12:03

  2. TYPO3com voted on patch set 1 V +1 10/29/18, 12:08 Completed build in 05m 09s on Mon, 29 Oct, 01:08 PM Test Summary: 49502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1577

  3. Benni Mack commented on patch set 1 CR -1 10/29/18, 16:13

    PharStreamWrapperInterceptor.php:38

    two spaces " "

    PharStreamWrapperInterceptor.php:91

    not PHP 73 compatible. could you use "%" instead of "#"?

    PharStreamWrapperInterceptor.php:122

    we can get rid of this line.
  4. Oliver Hader commented on patch set 2 10/29/18, 18:03

    Published edit on patch set 1.
  5. Oliver Hader commented on patch set 1 10/29/18, 18:05

    PharStreamWrapperInterceptor.php:91 Reply

    Only applies if used inside pattern, not as delimiter - http://php.net/manual/en/function.preg-quote.php
  6. TYPO3com voted on patch set 2 V +1 10/29/18, 18:10 Completed build in 06m 52s on Mon, 29 Oct, 07:10 PM Test Summary: 49502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1578

  7. Oliver Hader voted on patch set 2 V +2 CR +2 10/30/18, 08:05

  8. Oliver Hader merged patch set 3 10/30/18, 08:06