Review main Merged

58782[BUGFIX] Update karma

Andreas Kienast CR +2 V +2 Expert +789 −311 updated 10/31/18, 07:53

Commit message

karma is used for JavaScript based unit tests. The currently installed
version is aged and doesn't compile on newer systems anymore, thus the
package is updated to a recent version.

Used command:
yarn add karma@^3.1.0 --dev

Review

  • Code review CR +2
    • Oliver Hader +2
    • Daniel Goerz +1
    • Benni Mack +1
  • Verified V +2
    • Oliver Hader +2
    • Daniel Goerz +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Andreas Kienast uploaded patch set 1 10/29/18, 18:52

  2. TYPO3com voted on patch set 1 V +1 10/29/18, 19:03 Completed build in 10m 40s on Mon, 29 Oct, 08:03 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29834

  3. Benni Mack updated the commit message in patch set 2 10/30/18, 11:42

  4. Benni Mack voted on patch set 2 V +1 CR +1 10/30/18, 11:42

  5. Andreas Kienast updated the commit message in patch set 3 10/30/18, 11:48

  6. TYPO3com voted on patch set 2 V +1 10/30/18, 12:04 Completed build in 18m 29s on Tue, 30 Oct, 01:04 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29881

  7. TYPO3com voted on patch set 3 V +1 10/30/18, 12:08 Completed build in 14m 02s on Tue, 30 Oct, 01:08 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29882

  8. Benni Mack voted on patch set 3 V +1 CR +1 10/30/18, 12:20

  9. Daniel Goerz commented on patch set 3 10/30/18, 12:47

    Build still failing with node v11 for me. Still figuring out if this is due to my local system now somehow.
  10. Oliver Hader voted on patch set 3 V +2 CR +2 10/30/18, 13:06

  11. Oliver Hader merged patch set 4 10/30/18, 13:06

  12. Daniel Goerz voted on patch set 4 V +1 CR +1 10/31/18, 07:53