Review main Merged

58788[TASK] Test fully built css in bamboo

Christian Kuhn CR +2 V +2 Easy +28 −9 updated 10/30/18, 12:25

Commit message

Extend the "Lint scss ts" bamboo job to also build css
next to js and only after that verify with git status
no file changed. This should prevent outdated css as
recently fixed with #86789.
Additionally switch from npm to direct grunt calls,
to be in sync with runTests.sh and to allow kicking
npm from the docker images entirely.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Christian Kuhn +1
  • Verified V +2
    • Oliver Hader +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 913

  1. Christian Kuhn uploaded patch set 1 10/30/18, 08:28

  2. TYPO3com voted on patch set 1 V +1 10/30/18, 08:40 Completed build in 11m 15s on Tue, 30 Oct, 09:40 AM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29862

  3. Christian Kuhn uploaded patch set 2 10/30/18, 08:40

  4. TYPO3com voted on patch set 2 V +1 10/30/18, 08:49 Completed build in 09m 33s on Tue, 30 Oct, 09:49 AM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29863

  5. Andreas Kienast commented on patch set 2 10/30/18, 08:53

    AbstractCoreSpec.java:1176

    I think a single "grunt build" could replace all other three tasks
  6. Christian Kuhn uploaded patch set 3 10/30/18, 08:59

  7. Christian Kuhn updated the commit message in patch set 4 10/30/18, 09:07

  8. TYPO3com voted on patch set 3 V +1 10/30/18, 09:09 Completed build in 10m 04s on Tue, 30 Oct, 10:09 AM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29864

  9. Christian Kuhn commented on patch set 2 10/30/18, 09:09

    AbstractCoreSpec.java:1176 Reply Unresolved

    tried that: grunt build does even more than that and then changes for instance various js files from ck_editor on my side with different line endings ... i thus like to keep this seperated for now.
  10. TYPO3com voted on patch set 4 V +1 10/30/18, 09:19 Completed build in 11m 50s on Tue, 30 Oct, 10:19 AM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29865

  11. Christian Kuhn commented on patch set 4 V +1 CR +1 10/30/18, 09:20

    tested on bamboo testbed lolli: * run with not-current css: https://bamboo.typo3.com/browse/CORE-TL-LSTS-2240/log * run with ok css: https://bamboo.typo3.com/browse/CORE-TL-LSTS-2241/log
  12. Oliver Hader voted on patch set 4 V +2 CR +2 10/30/18, 12:25

  13. Oliver Hader merged patch set 5 10/30/18, 12:25