Review TYPO3_8-7 Merged

58791[TASK] Test fully built css in bamboo

Christian Kuhn CR +2 V +2 Easy +28 −9 updated 10/30/18, 12:26

Commit message

Extend the "Lint scss ts" bamboo job to also build css
next to js and only after that verify with git status
no file changed. This should prevent outdated css as
recently fixed with #86789.
Additionally switch from npm to direct grunt calls,
to be in sync with runTests.sh and to allow kicking
npm from the docker images entirely.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Christian Kuhn +1
  • Verified V +2
    • Oliver Hader +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/30/18, 10:21

  2. TYPO3com voted on patch set 1 V +1 10/30/18, 10:31 Completed build in 09m 57s on Tue, 30 Oct, 11:31 AM Test Summary: 60218 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3151

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/30/18, 10:32

  4. Oliver Hader voted on patch set 1 V +2 CR +2 10/30/18, 12:26

  5. Oliver Hader merged patch set 2 10/30/18, 12:26