Review main Merged

58795[BUGFIX] Adjust FrontendUserImageUpdateWizard

Stefan Neufeind CR +2 V +2 Easy +2 −3 updated 10/30/18, 21:30

Commit message

Make "Mark undone" and the migration itself work again.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Stefan Neufeind uploaded patch set 1 10/30/18, 10:46

  2. Stefan Neufeind commented on patch set 1 10/30/18, 10:47

    Just pushed the patch from Alexander to review. If possible please improve the commit-msg with some background :-)
  3. TYPO3com voted on patch set 1 V -1 10/30/18, 10:47 Completed build in 41s on Tue, 30 Oct, 11:47 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29871

  4. Benni Mack commented on patch set 1 10/30/18, 11:30

    tabs vs. spaces.
  5. Stefan Neufeind uploaded patch set 2 10/30/18, 11:37

  6. Stefan Neufeind commented on patch set 2 10/30/18, 11:38

    @Benni: Thanks, sure. I even ran cglFixMyCommit - but that only works before push, not before commiting :-)
  7. TYPO3com voted on patch set 2 V +1 10/30/18, 11:56 Completed build in 19m 16s on Tue, 30 Oct, 12:56 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29879

  8. Wouter Wolters voted on patch set 2 V +1 CR +1 10/30/18, 21:20

  9. Benni Mack voted on patch set 2 V +2 CR +2 10/30/18, 21:30

  10. Benni Mack merged patch set 3 10/30/18, 21:30