Review main Merged

58807[BUGFIX] Resolve strict type assertion in RecordStateFactory

Oliver Hader CR +2 V +2 Easy +1 −1 updated 12/05/18, 19:40

Commit message

Applying a strict "string" type to values that are "null" will
lead to type errors for TCA properties that are not configured
- most probably for "languageField", "transOrigPointerField"
or "translationSource".

see https://github.com/georgringer/news/issues/776

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Rico Drexler +1
    • Joerg Kummer +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Rico Drexler +1
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1112

  1. Oliver Hader uploaded patch set 1 10/31/18, 06:45

  2. TYPO3com voted on patch set 1 V +1 10/31/18, 06:54 Completed build in 08m 37s on Wed, 31 Oct, 07:54 AM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29911

  3. Georg Ringer voted on patch set 1 V +1 CR +1 10/31/18, 07:32

  4. Wouter Wolters voted on patch set 1 CR +1 10/31/18, 07:49

  5. Daniel Goerz voted on patch set 1 V +1 CR +1 10/31/18, 08:11

  6. Markus Klein voted on patch set 1 V +2 CR +2 10/31/18, 08:16

  7. Markus Klein merged patch set 2 10/31/18, 08:16

  8. Joerg Kummer voted on patch set 2 V +1 CR +1 10/31/18, 08:46

  9. Rico Drexler voted on patch set 2 V +1 12/05/18, 11:55

  10. Rico Drexler voted on patch set 2 CR +1 12/05/18, 11:55

  11. Oliver Klee commented on patch set 2 12/05/18, 14:52

    RecordStateFactory.php:103

    Wouldn't "?string" (i.e., a nullable type) have worked here?
  12. Oliver Hader commented on patch set 2 12/05/18, 19:40

    RecordStateFactory.php:103 Reply

    Probably yes...