58822[FEATURE] Support recursive in record sitemap
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Richard Haeser +1
-
Verified V +2
- Benni Mack +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1623
-
Georg Ringer uploaded patch set 1 11/01/18, 22:04
-
TYPO3com voted on patch set 1 V -1 11/01/18, 22:04 Completed build in 09s on Thu, 1 Nov, 11:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29936
-
Benni Mack commented on patch set 1 11/02/18, 08:52
-
Georg Ringer commented on patch set 1 11/02/18, 17:27
RecordsXmlSitemapDataProvider.php:70Replyyes, I didn't even test the code yet ;) -
Georg Ringer uploaded patch set 2 11/08/18, 20:40
-
TYPO3com voted on patch set 2 V -1 11/08/18, 20:40 Completed build in 08s on Thu, 8 Nov, 09:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30093
-
Benni Mack commented on patch set 3 11/08/18, 20:43
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V -1 11/08/18, 20:43 Completed build in 11s on Thu, 8 Nov, 09:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30094
-
Georg Ringer uploaded patch set 4 11/08/18, 20:55
-
Wouter Wolters voted on patch set 4 CR +1 11/08/18, 20:59
-
Georg Ringer uploaded patch set 5 11/08/18, 21:03
-
TYPO3com voted on patch set 4 V -1 11/08/18, 21:10 Completed build in 15m 17s on Thu, 8 Nov, 10:10 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30096
-
TYPO3com voted on patch set 5 V -1 11/08/18, 21:30 Completed build in 22m 09s on Thu, 8 Nov, 10:30 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30101
-
Georg Ringer rebased onto patch set 6 11/09/18, 07:22
-
TYPO3com voted on patch set 6 V -1 11/09/18, 07:31 Completed build in 09m 33s on Fri, 9 Nov, 08:31 AM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30104
-
Benni Mack commented on patch set 7 11/16/18, 10:15
Published edit on patch set 6. -
Richard Haeser voted on patch set 7 V +1 CR +1 11/16/18, 10:19
-
TYPO3com voted on patch set 7 V +1 11/16/18, 10:28 Completed build in 12m 46s on Fri, 16 Nov, 11:28 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30165
-
Guido Schmechel commented on patch set 7 11/16/18, 10:40
RecordsXmlSitemapDataProvider.php:68UnresolvedMaybe better check for $recursiveLevel > 0?RecordsXmlSitemapDataProvider.php:73UnresolvedMaybe GeneralUtility:intExplode? -
Jonas Eberle commented on patch set 7 11/16/18, 10:43
Feature-86826-RecursiveRecordSitemap.rst:14I suggest describing the meaning of the parameter (I would have understood it as a simple feature switch). E.g.: `recursive` refers to the number of levels taken into account beyond the `pid` page. (default:0)Feature-86826-RecursiveRecordSitemap.rst:19A full example: -
Benni Mack voted on patch set 7 V +2 CR +2 11/16/18, 10:46
-
Benni Mack merged patch set 8 11/16/18, 10:46
-
Benni Mack commented on patch set 8 11/16/18, 10:50
ah, I'm sorry, I didn't see your comments... If you feel to improve it, could you create a separate patch for that? would be awesome!
RecordsXmlSitemapDataProvider.php:70