Review main Merged

58822[FEATURE] Support recursive in record sitemap

Georg Ringer CR +2 V +2 Normal +64 −0 updated 11/16/18, 10:50

Commit message

A recursive configuration makes it a lot easier to provide
a sitemap for all records without touching the configuration
if a new sysfolder is created.

Review

  • Code review CR +2
    • Benni Mack +2
    • Richard Haeser +1
  • Verified V +2
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1623

  1. Georg Ringer uploaded patch set 1 11/01/18, 22:04

  2. TYPO3com voted on patch set 1 V -1 11/01/18, 22:04 Completed build in 09s on Thu, 1 Nov, 11:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29936

  3. Benni Mack commented on patch set 1 11/02/18, 08:52

    RecordsXmlSitemapDataProvider.php:70

    should we cast to (int) right away when handing in $this->config['recursive']?
  4. Georg Ringer commented on patch set 1 11/02/18, 17:27

    RecordsXmlSitemapDataProvider.php:70 Reply

    yes, I didn't even test the code yet ;)
  5. Georg Ringer uploaded patch set 2 11/08/18, 20:40

  6. TYPO3com voted on patch set 2 V -1 11/08/18, 20:40 Completed build in 08s on Thu, 8 Nov, 09:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30093

  7. Benni Mack commented on patch set 3 11/08/18, 20:43

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V -1 11/08/18, 20:43 Completed build in 11s on Thu, 8 Nov, 09:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30094

  9. Georg Ringer uploaded patch set 4 11/08/18, 20:55

  10. Wouter Wolters voted on patch set 4 CR +1 11/08/18, 20:59

  11. Georg Ringer uploaded patch set 5 11/08/18, 21:03

  12. TYPO3com voted on patch set 4 V -1 11/08/18, 21:10 Completed build in 15m 17s on Thu, 8 Nov, 10:10 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30096

  13. TYPO3com voted on patch set 5 V -1 11/08/18, 21:30 Completed build in 22m 09s on Thu, 8 Nov, 10:30 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30101

  14. Georg Ringer rebased onto patch set 6 11/09/18, 07:22

  15. TYPO3com voted on patch set 6 V -1 11/09/18, 07:31 Completed build in 09m 33s on Fri, 9 Nov, 08:31 AM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30104

  16. Benni Mack commented on patch set 7 11/16/18, 10:15

    Published edit on patch set 6.
  17. Richard Haeser voted on patch set 7 V +1 CR +1 11/16/18, 10:19

  18. TYPO3com voted on patch set 7 V +1 11/16/18, 10:28 Completed build in 12m 46s on Fri, 16 Nov, 11:28 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30165

  19. Guido Schmechel commented on patch set 7 11/16/18, 10:40

    RecordsXmlSitemapDataProvider.php:68 Unresolved

    Maybe better check for $recursiveLevel > 0?

    RecordsXmlSitemapDataProvider.php:73 Unresolved

    Maybe GeneralUtility:intExplode?
  20. Jonas Eberle commented on patch set 7 11/16/18, 10:43

    Feature-86826-RecursiveRecordSitemap.rst:14

    I suggest describing the meaning of the parameter (I would have understood it as a simple feature switch). E.g.: `recursive` refers to the number of levels taken into account beyond the `pid` page. (default:0)

    Feature-86826-RecursiveRecordSitemap.rst:19

    A full example:
  21. Benni Mack voted on patch set 7 V +2 CR +2 11/16/18, 10:46

  22. Benni Mack merged patch set 8 11/16/18, 10:46

  23. Benni Mack commented on patch set 8 11/16/18, 10:50

    ah, I'm sorry, I didn't see your comments... If you feel to improve it, could you create a separate patch for that? would be awesome!