Review main Abandoned

58825[TASK] Remove deprecated code from ClassSchema.php

Alexander Schnitzler CR 0 V 0 Hard +1 −764 updated 11/02/18, 12:19

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 1011

  1. Alexander Schnitzler uploaded patch set 1 11/02/18, 11:13

  2. Andreas Kienast commented on patch set 1 CR -1 11/02/18, 11:13

    This is a breaking change which also needs a ReST file.
  3. TYPO3com voted on patch set 1 V +1 11/02/18, 11:26 Completed build in 12m 48s on Fri, 2 Nov, 12:26 PM Test Summary: 48401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29949

  4. Alexander Schnitzler commented on patch set 1 11/02/18, 11:27

    > This is a breaking change which also needs a ReST file. Can you explain why this is breaking? Everything that has been deleted here has been marked deprecated in 9.x.
  5. Andreas Kienast commented on patch set 1 11/02/18, 11:30

    > Can you explain why this is breaking? > Everything that has been deleted here has been marked deprecated in > 9.x. Exactly, it's has been deprecated, but the code still works. If people still use deprecated code and this patch is merged, the previously working code breaks. Thus, it's a breaking change.
  6. Alexander Schnitzler commented on patch set 1 11/02/18, 11:34

    > > Can you explain why this is breaking? > > Everything that has been deleted here has been marked deprecated > in > > 9.x. > > Exactly, it's has been deprecated, but the code still works. If > people still use deprecated code and this patch is merged, the > previously working code breaks. Thus, it's a breaking change. So, what you say is: Every time we delete code, it is breaking. Because all of the code still works. Why do we deprecate stuff then in the first place?
  7. Andreas Kienast commented on patch set 1 11/02/18, 11:37

    > So, what you say is: Every time we delete code, it is breaking. > Because all of the code still works. Why do we deprecate stuff then > in the first place? That's correct. And I bet I don't have to explain the meaning of deprecations to you, do I? ;)
  8. Alexander Schnitzler commented on patch set 1 11/02/18, 11:46

    > > So, what you say is: Every time we delete code, it is breaking. > > Because all of the code still works. Why do we deprecate stuff > then > > in the first place? > > That's correct. And I bet I don't have to explain the meaning of > deprecations to you, do I? ;) Since when do we do that? Here's how I experienced deprecations and removals the last years. 1) We deprecate Code in Version X and say, the code won't work in X+1. 2) In X+1 we remove the Code without further notice. The stuff in this patch has been deprecated by me in 9.x and in 10.0 all of this should be gone. When people use this stuff in 9.x, they get tons of deprecation warnings. I created dozens of ReST documents and rules for the extension scanner. Why should we again tell users that the stuff they weren't intended to use in the previous version is now gone and that this is breaking? By definition something is only breaking if the public API doesn't work any more and we didn't tell people how the new public API looks like and is to be used. Tell me when this changed.
  9. Andreas Kienast commented on patch set 1 11/02/18, 11:52

    > Since when do we do that? > > Here's how I experienced deprecations and removals the last years. > > 1) We deprecate Code in Version X and say, the code won't work in > X+1. > 2) In X+1 we remove the Code without further notice. This rule has been abolished since we write ReST files. > Why should we again tell users that the stuff they weren't intended > to use in the previous version is now gone and that this is > breaking? To cite out contribution guide: "A patch moved or removed a specific part of core functionality that may break extensions if they use this part." https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/AddingDocumentation/Index.html#document-changes-changelog > By definition something is only breaking if the public API doesn't > work any more and we didn't tell people how the new public API > looks like and is to be used. Tell me when this changed. Enjoy: https://docs.typo3.org/typo3cms/extensions/core/Changelog/7.0/Index.html?highlight=deprecated#breaking-changes
  10. Frank Nägler commented on patch set 1 CR -1 11/02/18, 12:07

    agree regarding the missing rst file, also this patch can't be merged yet because we have not branched yet, so master means v9 at the moment.
  11. Alexander Schnitzler abandoned the change 11/02/18, 12:19

    Abandoned because if it is required to write ReST-files for breaking changes, this patch must be broken down to a lot of smaller patches. If someone is eager to do so, please go ahead.