Review main Merged

58829[TASK] Always send 404 response on hidden pages

Oliver Hader CR +2 V +2 Normal +221 −4 updated 09/22/20, 12:22

Commit message

As a backend user, it is possible to preview a hidden page & record
in a workspace, however, without a user it is not possible.

Adding the tests also discovered that access to a "hidden" page should
result in a 404 instead of 403 response (even though the page
has access restrictions or not) in a live environment.

This change adds tests to ensure this functionality is always working.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 3

Files 11

Review log 3655

Show 1730 earlier messages
  1. Oliver Hader uploaded patch set 1 11/02/18, 15:54

  2. TYPO3com voted on patch set 1 V -1 11/02/18, 16:05 Completed build in 11m 03s on Fri, 2 Nov, 05:05 PM Test Summary: 3 of 48837 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29963

  3. Oliver Hader commented on patch set 1 11/02/18, 16:07

    Args, testing-framework changes missing
  4. Oliver Hader uploaded patch set 2 11/02/18, 16:10

  5. TYPO3com voted on patch set 2 V -1 11/02/18, 16:19 Completed build in 08m 31s on Fri, 2 Nov, 05:19 PM Test Summary: 48350 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29964

  6. Oliver Hader commented on patch set 2 11/02/18, 16:24

    Needs to be updated to newer testing framework version once acceptance test setup is fixed again
  7. Oliver Hader uploaded patch set 3 11/03/18, 08:19

  8. TYPO3com voted on patch set 3 V +1 11/03/18, 08:29 Completed build in 09m 57s on Sat, 3 Nov, 09:29 AM Test Summary: 48429 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29980

  9. Oliver Hader rebased onto patch set 4 01/30/19, 15:57

  10. TYPO3com voted on patch set 4 V +1 01/30/19, 16:11 Completed build in 14m 02s on Wed, 30 Jan, 05:11 PM Test Summary: 46904 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31840

  11. Oliver Hader wrote 02/06/19, 15:17

    Topic set to DataHandler
  12. Oliver Hader rebased onto patch set 5 03/12/19, 21:30

  13. TYPO3com voted on patch set 5 V -1 03/12/19, 21:47 Completed build in 16m 42s on Tue, 12 Mar, 10:47 PM Test Summary: 1 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32683

  14. Benni Mack uploaded patch set 6 11/09/19, 13:58

  15. TYPO3com voted on patch set 6 V -1 11/09/19, 14:07 Completed build in 09m 18s on Sat, 9 Nov, 02:07 PM Test Summary: 3 of 48608 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38179

  16. Benni Mack uploaded patch set 7 11/09/19, 14:16

  17. TYPO3com voted on patch set 7 V -1 11/09/19, 14:25 Completed build in 08m 28s on Sat, 9 Nov, 02:25 PM Test Summary: 3 of 48608 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38185

  18. Oliver Hader rebased onto patch set 8 12/24/19, 11:18

  19. Oliver Hader uploaded patch set 9 12/24/19, 11:19

  20. Oliver Hader updated the commit message in patch set 10 12/24/19, 11:23

  21. TYPO3com voted on patch set 8 V -1 12/24/19, 11:29 Completed build in 11m 34s on Tue, 24 Dec, 11:29 AM Test Summary: 3 of 69584 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39567

  22. TYPO3com commented on patch set 9 12/24/19, 11:34 Completed build in 11m 29s on Tue, 24 Dec, 11:34 AM Test Summary: 3 of 69584 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39568

  23. TYPO3com voted on patch set 10 V -1 12/24/19, 11:38 Completed build in 09m 57s on Tue, 24 Dec, 11:38 AM Test Summary: 3 of 69584 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39569

  24. Benni Mack uploaded patch set 11 09/07/20, 19:04

  25. TYPO3com voted on patch set 11 V -1 09/07/20, 19:29 Completed build in 17m 52s on Mon, 7 Sep, 07:29 PM Test Summary: 3 of 73715 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5349

  26. Benni Mack uploaded patch set 12 09/07/20, 19:45

  27. TYPO3com voted on patch set 12 V +1 09/07/20, 19:56 Completed build in 10m 53s on Mon, 7 Sep, 07:56 PM Test Summary: 73230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5350

  28. Benni Mack updated the commit message in patch set 13 09/07/20, 21:10

  29. Benni Mack voted on patch set 13 V +1 CR +1 09/07/20, 21:21

  30. TYPO3com voted on patch set 13 V +1 09/07/20, 21:35 Completed build in 17m 35s on Mon, 7 Sep, 09:35 PM Test Summary: 73230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5353

  1. Christian Kuhn commented on patch set 13 CR -1 09/08/20, 11:34

    ActionTest.php:541 Unresolved

    missing @test ...
  2. Christian Kuhn uploaded patch set 14 09/08/20, 11:36

  3. TYPO3com voted on patch set 14 V -1 09/08/20, 11:50 Completed build in 14m 14s on Tue, 8 Sep, 11:50 AM Test Summary: 1 of 71702 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5364

  4. TYPO3com commented on patch set 14 09/08/20, 12:11 Completed build in 49m 42s on Tue, 8 Sep, 12:11 PM Test Summary: 3 of 73718 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5364

  5. Christian Kuhn commented on patch set 14 09/08/20, 12:12

    Look ma, I broke it by adding an @test ;)
  6. Benni Mack commented on patch set 14 09/08/20, 15:33

    > Patch Set 14: > > Look ma, I broke it by adding an @test ;) good. looks like calling a hidden page does not show a 404 but a 403 to unauthenticated visitors, this is bad!
  7. Oliver Hader commented on patch set 14 09/09/20, 08:58

    Looks like SiteRequestTest does not test hidden pages - thus, also a missing test case there
  8. Benni Mack uploaded patch set 15 09/09/20, 12:57

  9. Benni Mack updated the commit message in patch set 16 09/09/20, 12:59

  10. TYPO3com voted on patch set 15 V -1 09/09/20, 13:08 Completed build in 11m 21s on Wed, 9 Sep, 01:08 PM Test Summary: 3 of 73676 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5413

  11. TYPO3com voted on patch set 16 V -1 09/09/20, 13:15 Completed build in 16m 28s on Wed, 9 Sep, 01:15 PM Test Summary: 3 of 73664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5414

  12. Benni Mack uploaded patch set 17 09/09/20, 14:11

  13. TYPO3com voted on patch set 17 V +1 09/09/20, 14:22 Completed build in 11m 38s on Wed, 9 Sep, 02:22 PM Test Summary: 73191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5417

  14. Christian Kuhn voted on patch set 17 CR +1 09/09/20, 19:21

  15. Markus Klein commented on patch set 17 CR +1 09/09/20, 19:32

    Reads good on first reading-review
  16. Jörg Bösche voted on patch set 17 CR +1 09/10/20, 06:12

  17. Oliver Hader commented on patch set 17 09/10/20, 06:23

    TypoScriptFrontendController.php:1125

    Should it be ($requestedPageIsHidden || !$requestedPageRowWithoutGroupCheck) && empty($this->page))?
  18. Benni Mack commented on patch set 17 09/10/20, 07:20

    TypoScriptFrontendController.php:1125 Reply Unresolved

    this won't work. $this->page gets filled by the "next available parent page" by traversing through the rootline (Even if the page is hidden), so people could fall back to the next parent page (a stupid idea IMHO) when a page is unavailable. But only if no parent page is available a "404" was triggered previously. My change activated the functionality to send a 404 only if the requested page is hidden (not the others).
  19. Oliver Hader voted on patch set 17 CR +1 09/10/20, 10:35

  20. Benni Mack voted on patch set 17 V +1 CR +1 09/10/20, 11:08

  21. Benni Mack uploaded patch set 18 09/18/20, 20:39

  22. TYPO3com voted on patch set 18 V +1 09/18/20, 20:52 Completed build in 13m 16s on Fri, 18 Sep, 08:52 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5732

  23. Benni Mack voted on patch set 18 V +1 CR +1 09/21/20, 17:41

  24. Christian Kuhn voted on patch set 18 V +2 CR +2 09/22/20, 12:22

  25. Christian Kuhn merged patch set 19 09/22/20, 12:22