58830[TASK] Mark GeneralUtility::implodeArrayForUrl as deprecated
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+3 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-83334-GeneralUtilityImplodeArrayForUrl.rst1new+39 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −71
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.phpnew+91 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1420
-
Anja Leichsenring uploaded patch set 1 11/02/18, 16:21
-
TYPO3com voted on patch set 1 V -1 11/02/18, 16:21 Completed build in 11s on Fri, 2 Nov, 05:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29966
-
Anja Leichsenring commented on patch set 1 CR -2 11/02/18, 16:22
blocked until v10 branching has taken place. -
Anja Leichsenring uploaded patch set 2 11/02/18, 16:22
-
TYPO3com voted on patch set 2 V -1 11/02/18, 16:33 Completed build in 11m 28s on Fri, 2 Nov, 05:33 PM Test Summary: 156 of 48813 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29967
-
Anja Leichsenring commented on patch set 2 11/02/18, 16:36
tests are currently failing, because this change relies on https://review.typo3.org/c/55079. With it, it works. -
Anja Leichsenring rebased onto patch set 3 11/06/18, 16:07
-
TYPO3com voted on patch set 3 V +1 11/06/18, 16:17 Completed build in 10m 30s on Tue, 6 Nov, 05:17 PM Test Summary: 48446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30042
-
Wouter Wolters updated the commit message in patch set 4 11/08/18, 20:22
-
TYPO3com voted on patch set 4 V +1 11/08/18, 20:38 Completed build in 15m 09s on Thu, 8 Nov, 09:38 PM Test Summary: 48450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30092
-
Anja Leichsenring uploaded patch set 5 12/22/18, 17:29
-
Anja Leichsenring voted on patch set 5 CR 0 12/22/18, 17:30
-
TYPO3com voted on patch set 5 V -1 12/22/18, 17:31 Completed build in 01m 21s on Sat, 22 Dec, 06:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31105
-
Christian Kuhn commented on patch set 5 CR -1 12/22/18, 17:38
looks a bit half-done. what was the background? we missed the scanner entry in v9 but it has been deprecated already? if not, and if that method is not post-deprecated in v9, i'd opt to only deprecated that in master *after* all the other method removals have been finished. -
Anja Leichsenring uploaded patch set 6 12/22/18, 17:54
-
Anja Leichsenring commented on patch set 6 12/22/18, 17:56
this is no post-deprecation, but a real deprecation. The patch replacing the usages came in very late, and not all usages have been tackled yet. So the deprecation has been postponed until v10 development phase. -
Anja Leichsenring commented on patch set 6 V -1 12/22/18, 17:59
not happy, by the way, because two functions still use the deprecated method. The replacement caused errors, so it was reverted in this cases. No final decision has been made yet how to proceed. Blocking the patch therefor again, but would like to gather some feedback. -
TYPO3com voted on patch set 6 V +1 12/22/18, 18:06 Completed build in 11m 15s on Sat, 22 Dec, 07:06 PM Test Summary: 47795 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31112
-
Georg Ringer commented on patch set 6 12/22/18, 22:07
Deprecation-83334-GeneralUtilityImplodeArrayForUrl.rst:14is this really true? IMO the method is already available in 9.5 which should be added as well! otherwise people won't know that without deeper knowledge -
Anja Leichsenring abandoned the change 09/09/19, 08:36
obviously not