Review main Abandoned

58832[BUGFIX] Recreate ContentObjectRenderer to avoid side effects

Georg Ringer CR 0 V 0 Easy +1 −10 updated 11/03/18, 20:07

Commit message

Create always a new instance of the contentObjectRenderer to avoid
filling $data of FLUIDTEMPLATE with content of the content element.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 46

  1. Georg Ringer uploaded patch set 1 11/02/18, 18:05

  2. TYPO3com voted on patch set 1 V -1 11/02/18, 18:05 Completed build in 08s on Fri, 2 Nov, 07:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29971

  3. Georg Ringer uploaded patch set 2 11/03/18, 18:15

  4. TYPO3com voted on patch set 2 V -1 11/03/18, 18:24 Completed build in 08m 47s on Sat, 3 Nov, 07:24 PM Test Summary: 16 of 48835 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29985

  5. Benni Mack commented on patch set 2 11/03/18, 20:04

    hey georg, is this related to https://review.typo3.org/#/c/58661/ ?
  6. Georg Ringer abandoned the change 11/03/18, 20:07

    see https://review.typo3.org/#/c/58661/ for better solution