Review main Merged

58840[BUGFIX] Fix various issues in Core Updater

Andreas Kienast CR +2 V +2 Normal +28 −38 updated 11/08/18, 19:21

Commit message

- The click event for the update button is now bound to the modal and not
to the origin document, as this doesn't work in backend context.
- Fix rendering of flash messages
- Render error messages properly
- Fix download path of versions
- Drop unavailable "clear cache" action

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 11/04/18, 18:59

  2. TYPO3com voted on patch set 1 V +1 11/04/18, 19:10 Completed build in 10m 56s on Sun, 4 Nov, 08:10 PM Test Summary: 48423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29986

  3. Markus Klein voted on patch set 1 CR +1 11/04/18, 19:39

  4. Georg Ringer voted on patch set 1 V +1 CR +1 11/08/18, 18:29

  5. Jigal van Hemert voted on patch set 1 V +2 CR +2 11/08/18, 19:21

  6. Jigal van Hemert merged patch set 2 11/08/18, 19:21