58843[WIP][TASK] Allow adding custom attributes on HTML-Tag
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1317
-
Benjamin Kott uploaded patch set 1 11/05/18, 16:36
-
Benjamin Kott updated the commit message in patch set 2 11/05/18, 16:41
-
TYPO3com voted on patch set 1 V +1 11/05/18, 16:47 Completed build in 10m 26s on Mon, 5 Nov, 05:47 PM Test Summary: 48432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29991
-
TYPO3com voted on patch set 2 V +1 11/05/18, 16:51 Completed build in 10m 29s on Mon, 5 Nov, 05:51 PM Test Summary: 48432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29992
-
Georg Ringer commented on patch set 2 CR -1 11/05/18, 16:53
This is a feature and there multiple other ways to make that possible as ext as well -
Josef Glatz commented on patch set 2 11/22/18, 08:35
Tested: +1 Does this task have to be merged in 9?: Definitely! Still waiting for tests of that task/feature/bugfix.. whatever... -
Georg Ringer voted on patch set 2 CR 0 11/22/18, 08:40
-
Georg Ringer voted on patch set 2 V +1 CR +1 11/22/18, 09:05
-
Josef Glatz voted on patch set 2 V +1 CR +1 11/22/18, 09:09
-
Steffen Dietrich uploaded patch set 3 11/23/18, 12:38
-
TYPO3com voted on patch set 3 V +1 11/23/18, 12:54 Completed build in 16m 08s on Fri, 23 Nov, 01:54 PM Test Summary: 48486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30255
-
Anja Leichsenring commented on patch set 3 11/23/18, 20:35
CustomHTMLAttributesCest.php:43Unresolvedthis function can be left out here. This is copied from the Template Module Test Suite and must not be repeated here.CustomHTMLAttributesCest.php:105Unresolvedstrip the stuff down you don't need. Stick to what you really want to test. This repetition just slows down the test, and it is already tested in Template Module Test Suite.CustomHTMLAttributesCest.php:125Unresolvedadd another test case that demonstrates the overriding of existing tags (lang=de for example). -
Steffen Dietrich uploaded patch set 4 11/26/18, 13:55
-
TYPO3com voted on patch set 4 V +1 11/26/18, 14:05 Completed build in 10m 45s on Mon, 26 Nov, 03:05 PM Test Summary: 48485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30291
-
Steffen Dietrich commented on patch set 4 11/26/18, 14:08
The code is striped down and I added an additional test-case. On the other hand I m open for suggestions about the filename. I took the template-folder because I m creating a new template and change the settings. -
Anja Leichsenring commented on patch set 4 11/26/18, 21:55
you added a test for overriding the lang attribute, okay. But with this, you removed the test for just adding new params ... let's talk tomorrow, this seems to be a misunderstanding. -
Benjamin Kott abandoned the change 12/03/18, 20:04
abandon in favor of https://review.typo3.org/#/c/58976/