58846[BUGFIX] Remove dots from piVars set by _DEFAULT_PI_VARS
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Benni Mack +2
-
Verified V +2 Done
- Susi Moog +2
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 2
Review log 3243
Show 1318 earlier messages
-
Georg Ringer uploaded patch set 1 11/05/18, 17:58
-
Georg Ringer wrote 11/05/18, 17:59
Assignee added: Marc Bastian Heinrichs <typo3@mbh-software.de> -
Georg Ringer wrote 11/05/18, 17:59
Assignee changed from: Marc Bastian Heinrichs <typo3@mbh-software.de> to: Markus Klein <markus.klein@typo3.org> -
Georg Ringer wrote 11/05/18, 17:59
Assignee deleted: Markus Klein <markus.klein@typo3.org> -
Benni Mack commented on patch set 1 11/05/18, 18:00
AbstractPlugin.php:330can be assigned directly to $this->piVars = $typoScriptService -
TYPO3com voted on patch set 1 V -1 11/05/18, 18:09 Completed build in 10m 42s on Mon, 5 Nov, 07:09 PM Test Summary: 4 of 48844 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29996
-
Georg Ringer uploaded patch set 2 11/05/18, 18:18
-
TYPO3com voted on patch set 2 V -1 11/05/18, 18:18 Completed build in 17s on Mon, 5 Nov, 07:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29999
-
Georg Ringer uploaded patch set 3 11/05/18, 18:35
-
TYPO3com voted on patch set 3 V +1 11/05/18, 18:51 Completed build in 13m 28s on Mon, 5 Nov, 07:51 PM Test Summary: 48432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30004
-
Benni Mack commented on patch set 3 11/05/18, 18:57
AbstractPluginTest.php:118so this line above would be done then? -
Sebastian Fischer voted on patch set 3 CR +1 11/07/18, 10:31
-
Benni Mack commented on patch set 4 11/08/18, 19:51
Published edit on patch set 3. -
Benni Mack updated the commit message in patch set 5 11/08/18, 19:52
-
Benni Mack voted on patch set 5 V +1 CR +1 11/08/18, 20:10
-
TYPO3com voted on patch set 4 V +1 11/08/18, 20:13 Completed build in 15m 37s on Thu, 8 Nov, 09:13 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30087
-
Benni Mack commented on patch set 5 CR -1 11/08/18, 20:18
AbstractPlugin.php:349what if it isn't an array? then the value needs to be set as well.... -
TYPO3com voted on patch set 5 V +1 11/08/18, 20:21 Completed build in 22m 53s on Thu, 8 Nov, 09:21 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30088
-
Georg Ringer uploaded patch set 6 11/08/18, 20:58
-
Benni Mack voted on patch set 6 V +1 CR +1 11/08/18, 21:07
-
TYPO3com voted on patch set 6 V +1 11/08/18, 21:23 Completed build in 15m 37s on Thu, 8 Nov, 10:23 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30099
-
Markus Klein commented on patch set 6 11/09/18, 11:11
AbstractPlugin.php:327Does this line work at all? We still have the dots in the $tmp here and we merge with $this->piVars which is without dots I guess -
Wolfgang Klinger uploaded patch set 7 11/25/18, 15:50
-
TYPO3com voted on patch set 7 V +1 11/25/18, 16:02 Completed build in 11m 54s on Sun, 25 Nov, 05:02 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30273
-
Markus Klein commented on patch set 7 12/03/18, 08:09
Since we already have tests around defaultpivars, I suggest adding one more for this particular case? -
Markus Klein voted on patch set 7 V +1 CR +1 12/03/18, 20:35
-
Anja Leichsenring uploaded patch set 8 12/22/18, 19:00
-
Anja Leichsenring commented on patch set 8 12/22/18, 19:01
just rebased. Markus mentioned one missing test. I did not get the whole picture, but maybe someone can help out here? -
TYPO3com voted on patch set 8 V +1 12/22/18, 19:10 Completed build in 10m 03s on Sat, 22 Dec, 08:10 PM Test Summary: 47813 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31115
-
Markus Klein updated the commit message in patch set 9 12/22/18, 19:21
-
Markus Klein commented on patch set 9 12/22/18, 19:23
I meant that there is no test for a nested default pi var -
TYPO3com voted on patch set 9 V +1 12/22/18, 19:32 Completed build in 10m 35s on Sat, 22 Dec, 08:32 PM Test Summary: 47813 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31116
-
Anja Leichsenring wrote 09/09/19, 13:36
Removed reviewer Anja Leichsenring. -
Benni Mack commented on patch set 9 11/07/19, 21:44
Can we get some more tests here? I mean, this seems like we can quickly finish that one off by adding more tests... Otherwise I will tackle this tomorrow. I'm tired of having these easy tasks hanging around. -
Benni Mack uploaded patch set 10 11/09/19, 15:25
-
Benni Mack voted on patch set 10 V +1 CR +1 11/09/19, 15:26
-
Benni Mack uploaded patch set 11 11/09/19, 15:27
-
TYPO3com voted on patch set 10 V -1 11/09/19, 15:35 Completed build in 09m 41s on Sat, 9 Nov, 03:35 PM Test Summary: 1 of 48603 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38196
-
TYPO3com voted on patch set 11 V +1 11/09/19, 15:38 Completed build in 10m 55s on Sat, 9 Nov, 03:38 PM Test Summary: 48249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38197
-
Benni Mack voted on patch set 11 V +1 CR +1 11/09/19, 21:10
-
Susi Moog voted on patch set 11 V +2 CR +2 11/10/19, 08:23
-
Benni Mack voted on patch set 11 V +2 CR +2 11/10/19, 20:22
-
Benni Mack merged patch set 12 11/10/19, 20:22