Review main Merged

58847[BUGFIX] Hide internal prefix "cat:" in tags of upgrade docs

Georg Ringer CR +2 V +2 Easy +6 −4 updated 11/06/18, 18:21

Commit message

The prefix "cat:" is used internally and it doesn't make sense to
show it to a regular user. Neither does it provide more output nor is
"cat" a regular word.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Georg Ringer uploaded patch set 1 11/05/18, 19:30

  2. TYPO3com voted on patch set 1 V +1 11/05/18, 19:39 Completed build in 08m 50s on Mon, 5 Nov, 08:39 PM Test Summary: 48432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30006

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 11/05/18, 19:43

  4. Andreas Kienast uploaded patch set 2 11/05/18, 20:23

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 11/05/18, 20:23

  6. TYPO3com voted on patch set 2 V +1 11/05/18, 20:33 Completed build in 10m 10s on Mon, 5 Nov, 09:33 PM Test Summary: 48432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30008

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/05/18, 20:45

  8. Anja Leichsenring commented on patch set 2 11/05/18, 20:48

    maybe backport to v8, too? It outputs the same string.
  9. Andreas Kienast commented on patch set 2 11/06/18, 14:30

    > maybe backport to v8, too? It outputs the same string. I have no strong opniion on that one, I'd be fine with that
  10. Andreas Kienast updated the commit message in patch set 3 11/06/18, 14:32

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 11/06/18, 14:32

  12. TYPO3com voted on patch set 3 V +1 11/06/18, 14:44 Completed build in 11m 55s on Tue, 6 Nov, 03:44 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30037

  13. Anja Leichsenring voted on patch set 3 V +2 CR +2 11/06/18, 18:20

  14. Anja Leichsenring merged patch set 4 11/06/18, 18:20

  15. Anja Leichsenring commented on patch set 4 11/06/18, 18:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 97039eef1f00260296e950062f7caa1bb0ab8ed5