Review main Merged

58849[BUGFIX] Fix isMissing called on Null error

Bernhard Sirlinger CR +2 V +2 Easy +3 −1 updated 11/05/18, 21:58

Commit message

Add a Null check in FileLinktype->checkLink
function

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1319

  1. Bernhard Sirlinger uploaded patch set 1 11/05/18, 21:17

  2. TYPO3com voted on patch set 1 V -1 11/05/18, 21:17 Completed build in 09s on Mon, 5 Nov, 10:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30011

  3. Bernhard Sirlinger rebased onto patch set 2 11/05/18, 21:26

  4. TYPO3com commented on patch set 2 11/05/18, 21:26 Completed build in 09s on Mon, 5 Nov, 10:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30012

  5. Bernhard Sirlinger uploaded patch set 3 11/05/18, 21:29

  6. Wouter Wolters commented on patch set 3 CR -1 11/05/18, 21:30

    FileLinktype.php:63

    is_null is not in use in the core, please use !== null instead
  7. Bernhard Sirlinger uploaded patch set 4 11/05/18, 21:35

  8. Bernhard Sirlinger uploaded patch set 5 11/05/18, 21:36

  9. Bernhard Sirlinger commented on patch set 5 11/05/18, 21:37

    > Patch Set 3: Code-Review-1 > > (1 comment) Fixed it in patch set 5
  10. TYPO3com voted on patch set 3 V +1 11/05/18, 21:39 Completed build in 10m 06s on Mon, 5 Nov, 10:39 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30013

  11. Anja Leichsenring voted on patch set 5 V +1 CR +1 11/05/18, 21:43

  12. TYPO3com voted on patch set 4 V +1 11/05/18, 21:47 Completed build in 11m 54s on Mon, 5 Nov, 10:47 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30014

  13. Bernhard Sirlinger updated the commit message in patch set 6 11/05/18, 21:48

  14. Wouter Wolters voted on patch set 6 V +1 CR +1 11/05/18, 21:49

  15. TYPO3com voted on patch set 5 V +1 11/05/18, 21:50 Completed build in 13m 03s on Mon, 5 Nov, 10:50 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30015

  16. Anja Leichsenring commented on patch set 6 11/05/18, 21:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 77a3659562db252694ed205747e36e62d23b6856
  17. TYPO3com voted on patch set 6 V +1 11/05/18, 21:58 Completed build in 09m 25s on Mon, 5 Nov, 10:58 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30016

  18. Anja Leichsenring voted on patch set 6 V +2 CR +2 11/05/18, 21:58

  19. Anja Leichsenring merged patch set 7 11/05/18, 21:58