Review main Merged

58855[BUGFIX] Remove double encoding of dataStructureIdentifier

Stefan Froemken CR +2 V +2 Easy +7 −5 updated 11/08/18, 19:44

Commit message

As dataStructureIdentifier of FlexForms will be transferred
as JSON-encoded string, there is no need to call "json_encode"
again on that string.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 812

  1. Stefan Froemken uploaded patch set 1 11/06/18, 11:24

  2. TYPO3com voted on patch set 1 V -1 11/06/18, 11:35 Completed build in 10m 33s on Tue, 6 Nov, 12:35 PM Test Summary: 8 of 48876 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30026

  3. Benni Mack updated the commit message in patch set 2 11/06/18, 11:53

  4. Benni Mack commented on patch set 2 11/06/18, 11:53

    Hi Stefan. thanks for the patch. I removed the 9.5 releases branch, as there is no branch yet.
  5. TYPO3com voted on patch set 2 V -1 11/06/18, 12:03 Completed build in 09m 20s on Tue, 6 Nov, 01:03 PM Test Summary: 8 of 48876 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30027

  6. Stefan Froemken uploaded patch set 3 11/06/18, 12:49

  7. TYPO3com voted on patch set 3 V -1 11/06/18, 12:50 Completed build in 10s on Tue, 6 Nov, 01:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30028

  8. Stefan Froemken uploaded patch set 4 11/06/18, 13:33

  9. TYPO3com voted on patch set 4 V +1 11/06/18, 13:44 Completed build in 11m 22s on Tue, 6 Nov, 02:44 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30030

  10. Benni Mack voted on patch set 4 V +1 CR +1 11/08/18, 19:38

  11. Georg Ringer voted on patch set 4 V +2 CR +2 11/08/18, 19:44

  12. Georg Ringer merged patch set 5 11/08/18, 19:44