Review main Merged Breaking

58858[!!!][BUGFIX] Remove f:spaceless from default layout

Georg Ringer CR +2 V +2 Easy +36 −2 updated 07/05/19, 13:25

Commit message

As the ViewHelper `f:spaceless` removes too many spaces it should not be
used in the default layouts.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Torben Hansen +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Torben Hansen +1
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1922

  1. Georg Ringer uploaded patch set 1 11/06/18, 15:11

  2. Markus Klein voted on patch set 1 V +1 CR +1 11/06/18, 15:13

  3. TYPO3com voted on patch set 1 V +1 11/06/18, 15:23 Completed build in 11m 55s on Tue, 6 Nov, 04:23 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30040

  4. Claus Due commented on patch set 1 CR +1 11/06/18, 15:42

    I agree entirely that we do not want to impose the decision of f:spaceless or not, on every content type. It's fine to use in some contexts but becomes unsafe if you use it on things like content types that contain RTEs that can contain pretty much any type of tags and/or whitespace formatting. Automatic +1 from me.
  5. Benjamin Kott commented on patch set 1 CR -1 11/06/18, 16:09

    this one need atleast the be marked as breaking, removing this can result in a lot of problems. if you assume that its there in the first place also i prefer it only to be applied to master for 10.x
  6. Markus Klein commented on patch set 1 11/06/18, 16:44

    Can you please tell me the problems you see? I don't see any problems in adding more spaces to the output of a CE so far
  7. Josef Glatz commented on patch set 1 V +1 CR +1 11/06/18, 17:12

    From my perspective, this Looks like the best solution.
  8. Helmut Hummel voted on patch set 1 CR +1 11/06/18, 18:04

  9. Helmut Hummel commented on patch set 1 11/06/18, 18:07

    @Benjamin Kott: I'm fine with keeping it there in case you have an idea how to fix the RTE content issue otherwise. Or should we advise every user to change the layout file to be able to always render RTE content correctly? Might also be an option.
  10. Benjamin Kott commented on patch set 1 11/07/18, 09:36

    Removing the spaceless viewhelper is a massive change in behaviour during released versions that WILL lead to visual differences. Please see very very simple example: https://codepen.io/benjaminkott/pen/dQYwwy This will make the change breaking, and so the change must atleast be marked as beeing that. If you rely on these to reduce for example spacing between buttons or other examples. You will need to adapt your templates and override the layout if you are currently not doing this. In addition we reintroduce a lot of unnessesary bloat we tried to remove in the first place. That means if you are fine with the current solution you will now need to take additional actions to optimize the html output. Means, whatever we will change, it will be breaking in some kind or another. This is why i prefer not to make any backports to older versions in this area. But since v9.5 is almost fresh out of the door we can/should make an exception for this one. But i would still like to see an option that keeps the compression and the removal of bloat, but is handling block and inline elements differently/better.
  11. Helmut Hummel commented on patch set 1 CR 0 11/07/18, 16:30

    ok, seems indeed a bit more complicated
  12. Benni Mack updated the commit message in patch set 2 12/14/18, 10:08

  13. TYPO3com voted on patch set 2 V +1 12/14/18, 11:30 Completed build in 34m 40s on Fri, 14 Dec, 12:30 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30704

  14. Jörg Bösche voted on patch set 2 CR +1 12/20/18, 13:07

  15. Benjamin Kott commented on patch set 2 V -1 CR -1 12/20/18, 13:10

    Patch needs to be marked as breaking, it alters the frontend output and will result in a different display of the website
  16. Anja Leichsenring uploaded patch set 3 06/18/19, 11:14

  17. TYPO3com voted on patch set 3 V +1 06/18/19, 11:28 Completed build in 13m 36s on Tue, 18 Jun, 01:28 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34422

  18. Anja Leichsenring voted on patch set 3 V +1 CR +1 06/19/19, 08:11

  19. Benjamin Kott voted on patch set 3 V +1 CR +1 06/19/19, 08:13

  20. Torben Hansen voted on patch set 3 V +1 CR +1 07/05/19, 13:08

  21. Anja Leichsenring voted on patch set 3 V +2 CR +2 07/05/19, 13:25

  22. Anja Leichsenring merged patch set 4 07/05/19, 13:25