Review main Merged

58859[BUGFIX] Include DB queries with free mode records

Benni Mack CR +2 V +2 Normal +83 −36 updated 11/08/18, 16:41

Commit message

With the new site handling, the overlayType for fetching
records in the frontend context is always set to
OVERLAYS_ON_WITH_FLOATING, which resolves to
the previous TypoScript settings:
- config.sys_language_overlay = 1
- styles.content.get.select.includeRecordsWithoutDefaultTranslation = 1

However, the place where "includeRecordsWithoutDefaultTranslation"
is evaluated does not check for the actual
Language Aspect of the Context API, which makes
it impossible to fetch records without "l10n_parent"
= (free mode), except for setting this option
explicitly on each TypoScript "select." query.

The patch moves the functionality into a separate method,
which allows to better unit test all options.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Chris Müller +1
  • Verified V +2
    • Anja Leichsenring +2
    • Chris Müller +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 11/06/18, 15:27

  2. TYPO3com voted on patch set 1 V -1 11/06/18, 15:38 Completed build in 10m 27s on Tue, 6 Nov, 04:38 PM Test Summary: 36 of 48876 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30041

  3. Benni Mack uploaded patch set 2 11/06/18, 16:20

  4. TYPO3com voted on patch set 2 V +1 11/06/18, 16:29 Completed build in 09m 46s on Tue, 6 Nov, 05:29 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30044

  5. Chris Müller voted on patch set 2 V +1 11/07/18, 08:53

  6. Chris Müller voted on patch set 2 CR +1 11/07/18, 12:41

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 11/08/18, 16:41

  8. Anja Leichsenring merged patch set 3 11/08/18, 16:41