Review main Abandoned

58861[WIP][FEATURE] Allow css files to be included into footer

Benjamin Kott CR 0 V 0 Hard +397 −59 updated 02/27/20, 11:29

Commit message

Introduces:
page.includeCSSFooter
page.includeCSSFooterLibs

TODO:
- Write RST
- Prepare Documentation Update
- Add UnitTest to check if files are correctly splitted on concatenation
- Useful commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 8

Review log 79

  1. Benjamin Kott uploaded patch set 1 11/06/18, 17:43

  2. TYPO3com voted on patch set 1 V +1 11/06/18, 17:52 Completed build in 09m 48s on Tue, 6 Nov, 06:52 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30045

  3. Andreas Kienast commented on patch set 1 11/06/18, 19:29

    PageRenderer.php:2869

    &$cssFooter...
  4. Benjamin Kott uploaded patch set 2 11/07/18, 14:14

  5. Benjamin Kott commented on patch set 1 11/07/18, 14:17

    PageRenderer.php:2869 Reply

    Done
  6. TYPO3com voted on patch set 2 V +1 11/07/18, 14:24 Completed build in 09m 59s on Wed, 7 Nov, 03:24 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30052

  7. Frank Nägler commented on patch set 2 05/31/19, 13:54

    no activity on this patch since months, is anyone still working on it?
  8. Benni Mack commented on patch set 2 02/27/20, 11:28

    I'd recommend abandoning this feature now and actually use a "priority" flag now which could be used in conjunction with AssetCollector now?
  9. Benjamin Kott abandoned the change 02/27/20, 11:29

    moving on