Review main Abandoned

58864[TASK] Testscenario: create, edit and publish new Workspace

Steffen Dietrich CR 0 V 0 Hard +264 −8 updated 09/10/19, 05:40

Commit message

Added an acceptance test

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1425

  1. Steffen Dietrich uploaded patch set 1 11/07/18, 08:42

  2. Steffen Dietrich uploaded patch set 2 11/07/18, 08:46

  3. TYPO3com voted on patch set 2 V -1 11/07/18, 08:46 Completed build in 11s on Wed, 7 Nov, 09:46 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30049

  4. TYPO3com voted on patch set 1 V +1 11/07/18, 08:51 Completed build in 09m 06s on Wed, 7 Nov, 09:51 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30048

  5. Steffen Dietrich uploaded patch set 3 11/07/18, 15:14

  6. TYPO3com voted on patch set 3 V -1 11/07/18, 15:14 Completed build in 10s on Wed, 7 Nov, 04:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30053

  7. Steffen Dietrich uploaded patch set 4 11/08/18, 08:58

  8. TYPO3com voted on patch set 4 V -1 11/08/18, 09:07 Completed build in 09m 13s on Thu, 8 Nov, 10:07 AM Test Summary: 1 of 48877 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30064

  9. Steffen Dietrich uploaded patch set 5 11/08/18, 18:26

  10. TYPO3com voted on patch set 5 V -1 11/08/18, 18:37 Completed build in 10m 18s on Thu, 8 Nov, 07:37 PM Test Summary: 1 of 48883 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30076

  11. Steffen Dietrich uploaded patch set 6 11/09/18, 13:17

  12. TYPO3com voted on patch set 6 V -1 11/09/18, 13:26 Completed build in 09m 04s on Fri, 9 Nov, 02:26 PM Test Summary: 1 of 48879 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30110

  13. Steffen Dietrich uploaded patch set 7 11/12/18, 12:40

  14. TYPO3com voted on patch set 7 V -1 11/12/18, 12:49 Completed build in 08m 48s on Mon, 12 Nov, 01:49 PM Test Summary: 1 of 48878 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30127

  15. Steffen Dietrich uploaded patch set 8 11/13/18, 08:53

  16. TYPO3com voted on patch set 8 V -1 11/13/18, 09:03 Completed build in 09m 42s on Tue, 13 Nov, 10:03 AM Test Summary: 1 of 48878 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30129

  17. Steffen Dietrich uploaded patch set 9 11/13/18, 09:22

  18. TYPO3com voted on patch set 9 V +1 11/13/18, 09:30 Completed build in 07m 57s on Tue, 13 Nov, 10:30 AM Test Summary: 48466 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30130

  19. Steffen Dietrich uploaded patch set 10 01/17/19, 10:05

  20. TYPO3com voted on patch set 10 V -1 01/17/19, 10:36 Completed build in 22m 02s on Thu, 17 Jan, 11:36 AM Test Summary: 2 of 47173 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31574

  21. Steffen Dietrich uploaded patch set 11 01/17/19, 12:55

  22. TYPO3com voted on patch set 11 V +1 01/17/19, 13:06 Completed build in 10m 53s on Thu, 17 Jan, 02:06 PM Test Summary: 47038 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31580

  23. Anja Leichsenring voted on patch set 11 V +1 CR +1 01/18/19, 14:07

  24. Susi Moog commented on patch set 11 CR -1 02/01/19, 16:49

    SiteModuleCest.php:108

    I'd avoid using bool args in test methods - instead split the method in multiple parts - basic setup, add "styled content" || add default rendering

    SiteModuleCest.php:139

    should be singular "Site Configuration" (also in comment) to be consistent.

    WorkspacesCest.php:48

    use a more speaking name, please - what's it supposed to mean? (is it publish page to live or is it edit page in live workspace?) - feel free to also add a short summary in the comment.

    WorkspacesCest.php:101

    same as above, add a short summary in the comment to make it clearer what happens here.
  25. Benni Mack abandoned the change 09/10/19, 05:40

    no progress for while, abandoning this change for now