Review main Merged

58866[TASK] Remove fluid namespace in sitemap template

Georg Ringer CR +2 V +2 Easy +1 −1 updated 11/08/18, 16:33

Commit message

There is no need to keep the fluid namespace definition in the template.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Josef Glatz +1
  • Verified V +2
    • Anja Leichsenring +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Georg Ringer uploaded patch set 1 11/07/18, 14:00

  2. TYPO3com voted on patch set 1 V +1 11/07/18, 14:10 Completed build in 10m 07s on Wed, 7 Nov, 03:10 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30051

  3. Josef Glatz commented on patch set 1 11/07/18, 20:10

    In general this change is OK. But would it be better to extend the template mechanisms to automatically remove such namespace definitions in a xml template?
  4. Markus Klein updated the commit message in patch set 2 11/08/18, 01:59

  5. TYPO3com voted on patch set 2 V +1 11/08/18, 02:09 Completed build in 09m 23s on Thu, 8 Nov, 03:09 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30063

  6. Josef Glatz voted on patch set 2 V +1 CR +1 11/08/18, 05:40

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 11/08/18, 16:33

  8. Anja Leichsenring merged patch set 3 11/08/18, 16:33