58867[BUGFIX] Disable file compression for external urls in js and css includes
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Josef Glatz +1
- Daniel Goerz +1
- Anja Leichsenring +1
- Gerhard Rupp +1
- Jörg Bösche +1
- Willi Wehmeier +1
-
Verified V +2
- Jan Helke +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1517
-
Benjamin Kott uploaded patch set 1 11/07/18, 16:45
-
TYPO3com voted on patch set 1 V +1 11/07/18, 16:55 Completed build in 09m 42s on Wed, 7 Nov, 05:55 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30055
-
Georg Ringer commented on patch set 1 11/07/18, 17:08
There is no 9.5 branch and no 7.6 pls -
Wouter Wolters updated the commit message in patch set 2 11/07/18, 18:44
-
TYPO3com voted on patch set 2 V +1 11/07/18, 18:55 Completed build in 10m 26s on Wed, 7 Nov, 07:55 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30056
-
Anja Leichsenring commented on patch set 2 V +1 CR +1 11/07/18, 19:22
tested by looking at Benjis Screen. -
Josef Glatz voted on patch set 2 CR +1 11/07/18, 20:11
-
Daniel Goerz voted on patch set 2 CR +1 11/08/18, 10:17
-
Jigal van Hemert commented on patch set 2 11/08/18, 20:08
If compression is disabled for external files, shouldn't concatenation also be disabled? I thought that 'external' just disabled the check that the file exists, which could be expensive for remote files, and that the other options created a local copy which could be concatenated and/or compressed. This change is also breaking IMO. -
Willi Wehmeier voted on patch set 2 CR +1 11/20/18, 06:55
-
Jörg Bösche voted on patch set 2 CR +1 12/06/18, 12:50
-
Jan Helke voted on patch set 2 V +2 CR +2 12/07/18, 13:11
-
Jan Helke merged patch set 3 12/07/18, 13:11
-
Stephan Großberndt commented on patch set 3 12/14/18, 10:51
What about the backport to 8.7? Please respond here. -
Benni Mack commented on patch set 3 02/07/19, 06:42
this one has been flying around here, I'm actually against backporting that one to 8.7 - Benji, speak up if you see a necessity here. -
Benjamin Kott commented on patch set 3 02/19/19, 16:14
I do not consider this a critical bugfix since it can be avoided. But it can lead to problems for new users that are unaware of these options and to not grasp 100% what's going on - so they are probably also not aware how to fix it since we do not explain it correctly in the documentation. If we want to avoid that users run into this trap, I would consider this a good to backport this patch. It´s only about avoiding configuration mistakes that we can resolve easily. -
Gerhard Rupp commented on patch set 3 CR +1 04/03/19, 22:32
I can´t share Bennis point of view. As the special handling of external files is nowhere documented it should also be fixed for 8.7. It was time-consuming to debug this error (in conjuntion with other extensions). No one else should have to do this again.