Review main Merged

58868[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter

Georg Ringer CR +2 V +2 Easy +1 −1 updated 11/19/18, 07:52

Commit message

The return value of the hmac check is a string and must be casted to
an integer as the method using the value requires an integer.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
    • Nicole Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 11/07/18, 21:42

  2. TYPO3com voted on patch set 1 V +1 11/07/18, 21:53 Completed build in 10m 56s on Wed, 7 Nov, 10:53 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30057

  3. Wouter Wolters voted on patch set 1 CR +1 11/08/18, 20:19

  4. Benni Mack voted on patch set 1 V +1 CR +2 11/14/18, 05:28

  5. Oliver Klee commented on patch set 1 11/14/18, 09:15

    UploadedFileReferenceConverter.php:219

    Can't we put the int cast here? Then we we won't need the additional ternary operator.
  6. Benni Mack commented on patch set 1 11/15/18, 10:40

    UploadedFileReferenceConverter.php:219 Reply

    this if condition is already quite lengthy. Adding a separate line makes it more readable IMHO
  7. Oliver Klee commented on patch set 1 11/15/18, 10:41

    UploadedFileReferenceConverter.php:219 Reply

    I wasn't thinking about an additional line, but about an (int) right before the $this->hashService->…
  8. Nicole Hummel commented on patch set 1 CR -1 11/19/18, 00:29

    UploadedFileReferenceConverter.php:219 Reply

    I'm for the (int) casting as well. Will push a new patch set
  9. Nicole Hummel uploaded patch set 2 11/19/18, 00:32

  10. Nicole Hummel voted on patch set 2 V +1 CR +1 11/19/18, 00:33

  11. TYPO3com voted on patch set 2 V +1 11/19/18, 00:44 Completed build in 11m 07s on Mon, 19 Nov, 01:44 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30191

  12. Josef Glatz voted on patch set 2 CR +1 11/19/18, 04:22

  13. Benni Mack voted on patch set 2 V +2 CR +2 11/19/18, 07:52

  14. Benni Mack merged patch set 3 11/19/18, 07:52

  15. Benni Mack commented on patch set 3 11/19/18, 07:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 304c9595372495b300347d01a79ac52938acd5ed