58868[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Josef Glatz +1
- Nicole Hummel +1
-
Verified V +2
- Benni Mack +2
- Nicole Hummel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1315
-
Georg Ringer uploaded patch set 1 11/07/18, 21:42
-
TYPO3com voted on patch set 1 V +1 11/07/18, 21:53 Completed build in 10m 56s on Wed, 7 Nov, 10:53 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30057
-
Wouter Wolters voted on patch set 1 CR +1 11/08/18, 20:19
-
Benni Mack voted on patch set 1 V +1 CR +2 11/14/18, 05:28
-
Oliver Klee commented on patch set 1 11/14/18, 09:15
-
Benni Mack commented on patch set 1 11/15/18, 10:40
UploadedFileReferenceConverter.php:219Replythis if condition is already quite lengthy. Adding a separate line makes it more readable IMHO -
Oliver Klee commented on patch set 1 11/15/18, 10:41
UploadedFileReferenceConverter.php:219ReplyI wasn't thinking about an additional line, but about an (int) right before the $this->hashService->… -
Nicole Hummel commented on patch set 1 CR -1 11/19/18, 00:29
UploadedFileReferenceConverter.php:219ReplyI'm for the (int) casting as well. Will push a new patch set -
Nicole Hummel uploaded patch set 2 11/19/18, 00:32
-
Nicole Hummel voted on patch set 2 V +1 CR +1 11/19/18, 00:33
-
TYPO3com voted on patch set 2 V +1 11/19/18, 00:44 Completed build in 11m 07s on Mon, 19 Nov, 01:44 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30191
-
Josef Glatz voted on patch set 2 CR +1 11/19/18, 04:22
-
Benni Mack voted on patch set 2 V +2 CR +2 11/19/18, 07:52
-
Benni Mack merged patch set 3 11/19/18, 07:52
-
Benni Mack commented on patch set 3 11/19/18, 07:52
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 304c9595372495b300347d01a79ac52938acd5ed
UploadedFileReferenceConverter.php:219