Review main Merged

58870[BUGFIX] Add proper scope for styling of DebugExceptionHandler

Georg Ringer CR +2 V +2 Normal +47 −46 updated 12/10/18, 09:38

Commit message

The styling of the debug output is "namespaced" with `.exception-page`
to avoid influencing other CSS definitions.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Andreas Kienast +1
    • Markus Poerschke +1
  • Verified V +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Andreas Kienast +1
    • Markus Poerschke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1720

  1. Georg Ringer uploaded patch set 1 11/07/18, 22:36

  2. Markus Poerschke voted on patch set 1 CR +1 11/07/18, 22:43

  3. TYPO3com voted on patch set 1 V +1 11/07/18, 22:47 Completed build in 11m 04s on Wed, 7 Nov, 11:47 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30062

  4. Josef Glatz voted on patch set 1 CR +1 11/08/18, 04:01

  5. Andreas Wolf uploaded patch set 2 11/14/18, 10:05

  6. Andreas Wolf commented on patch set 2 V +1 CR +1 11/14/18, 10:06

    Added scoping for the body tag, to fix the font size changing e.g. when an AJAX error occurs in the DB analyzer (when logged into the backend, did not check standalone, but I presume it was the same there).
  7. TYPO3com voted on patch set 2 V +1 11/14/18, 10:16 Completed build in 10m 34s on Wed, 14 Nov, 11:16 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30138

  8. Andreas Kienast commented on patch set 2 CR -1 12/07/18, 20:39

    The current state doesn't solve the issue. The debugger output is within .exception-page, which makes the output even worse.
  9. Andreas Kienast uploaded patch set 3 12/07/18, 20:49

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 12/07/18, 20:50

  11. Florian Peters commented on patch set 3 V -1 12/07/18, 20:54

    With big debug value (over page size) the scrolling isn't working
  12. Georg Ringer voted on patch set 3 V +1 CR +1 12/07/18, 20:54

  13. Andreas Kienast commented on patch set 3 12/07/18, 20:59

    Scrolling is even broken without that patch. The behavior was introduced with https://forge.typo3.org/issues/83841
  14. Florian Peters voted on patch set 3 V 0 12/07/18, 21:00

  15. Josef Glatz voted on patch set 3 V +1 CR +1 12/07/18, 21:00

  16. TYPO3com voted on patch set 3 V +1 12/07/18, 21:04 Completed build in 14m 04s on Fri, 7 Dec, 10:04 PM Test Summary: 48712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30526

  17. Markus Poerschke commented on patch set 3 12/10/18, 09:35

    The output of DebuggerUtility::var_dump is now readable and works. There is only one drawback: the Debug output is overlapping the exception messages, because the <div>-container is set to position absolute for scrolling. (a solution could be: no top:0 attribute for .exception-page and give body and the div a height: 100% In my opinion the debug page should not handle the scrolling. This is a bug from the outer container that says: scrolling="no". If that is removed it works.
  18. Markus Poerschke voted on patch set 3 V +1 CR +1 12/10/18, 09:37

  19. Georg Ringer voted on patch set 3 V +2 CR +2 12/10/18, 09:38

  20. Georg Ringer merged patch set 4 12/10/18, 09:38