Review main Merged

58872[TASK] Remove leftovers of "options.uploadFieldsInTopOfEB"

Georg Ringer CR +2 V +2 Easy +0 −4 updated 11/08/18, 20:05

Commit message

With #80463 - before v8 LTS - the setting
"options.uploadFieldsInTopOfEB" has been removed from the templates,
no need to check the value inside the PHP code anymore.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 710

  1. Georg Ringer uploaded patch set 1 11/08/18, 12:57

  2. TYPO3com voted on patch set 1 V +1 11/08/18, 13:07 Completed build in 09m 54s on Thu, 8 Nov, 02:07 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30066

  3. Benni Mack commented on patch set 1 CR -1 11/08/18, 19:32

    this one is also in t3editor... typoscript.js "uploadFieldsInTopOfEB"
  4. Georg Ringer uploaded patch set 2 11/08/18, 19:42

  5. Benni Mack updated the commit message in patch set 3 11/08/18, 19:43

  6. Benni Mack voted on patch set 3 V +1 CR +1 11/08/18, 19:43

  7. TYPO3com voted on patch set 2 V +1 11/08/18, 19:55 Completed build in 12m 57s on Thu, 8 Nov, 08:55 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30082

  8. TYPO3com voted on patch set 3 V +1 11/08/18, 20:02 Completed build in 16m 38s on Thu, 8 Nov, 09:02 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30083

  9. Anja Leichsenring voted on patch set 3 V +2 CR +2 11/08/18, 20:05

  10. Anja Leichsenring merged patch set 4 11/08/18, 20:05