58873[TASK] Show flash message if value is changed because unique value is required
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- Wolfgang Klinger +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1926
Show 1 earlier messages
-
Georg Ringer uploaded patch set 1 11/08/18, 13:17
-
Georg Ringer wrote 11/08/18, 13:17
Assignee added: Benjamin Kott <benjamin.kott@outlook.com> -
TYPO3com voted on patch set 1 V -1 11/08/18, 13:27 Completed build in 09m 59s on Thu, 8 Nov, 02:27 PM Test Summary: 6 of 48876 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30067
-
Georg Ringer wrote 11/08/18, 18:44
Assignee deleted: Benjamin Kott <benjamin.kott@outlook.com> -
Georg Ringer uploaded patch set 2 11/08/18, 18:53
-
TYPO3com voted on patch set 2 V +1 11/08/18, 19:05 Completed build in 11m 48s on Thu, 8 Nov, 08:05 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30077
-
Oliver Klee updated the commit message in patch set 3 11/08/18, 19:10
-
TYPO3com voted on patch set 3 V +1 11/08/18, 19:21 Completed build in 10m 30s on Thu, 8 Nov, 08:21 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30078
-
Benni Mack commented on patch set 3 CR -1 11/08/18, 21:02
DataHandler.php:2796originally, this stuff was used while logging, and then printLogErrorMessages() shows the changes. This way, DataHandler continues to work on CLI. -
Georg Ringer commented on patch set 3 11/28/18, 17:24
@benni: sorry don't get what you mean -
Josef Glatz rebased onto patch set 4 03/15/19, 21:18
-
Josef Glatz commented on patch set 4 03/15/19, 21:20
The patch works as expected. @benni Can you please give feedback on your vote? -
TYPO3com voted on patch set 4 V +1 03/15/19, 21:33 Completed build in 14m 54s on Fri, 15 Mar, 10:33 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32773
-
Benni Mack uploaded patch set 5 03/16/19, 09:20
-
Benni Mack commented on patch set 5 03/16/19, 09:29
@georg. this is what I meant :) I know there are other places in DataHandler where Flashmessage is used and IMHO this is wrong. -
TYPO3com voted on patch set 5 V -1 03/16/19, 09:36 Completed build in 15m 36s on Sat, 16 Mar, 10:36 AM Test Summary: 6 of 47590 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32783
-
Josef Glatz uploaded patch set 6 03/16/19, 11:13
-
TYPO3com voted on patch set 6 V +1 03/16/19, 11:26 Completed build in 13m 11s on Sat, 16 Mar, 12:26 PM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32787
-
Josef Glatz voted on patch set 6 V +1 CR +1 03/16/19, 11:36
-
Benni Mack uploaded patch set 7 03/16/19, 11:38
-
Wolfgang Klinger voted on patch set 7 CR +1 03/16/19, 11:51
-
TYPO3com voted on patch set 7 V +1 03/16/19, 11:52 Completed build in 13m 31s on Sat, 16 Mar, 12:52 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32790
-
Georg Ringer voted on patch set 7 V +1 CR +1 03/16/19, 11:57
-
Josef Glatz voted on patch set 7 V +1 CR +1 03/16/19, 12:28
-
Benni Mack voted on patch set 7 V +2 CR +2 03/16/19, 12:35
-
Benni Mack merged patch set 8 03/16/19, 12:35