Review main Merged

58879[FEATURE] Support feature toggle in expression language

Anja Leichsenring CR +2 V +2 Normal +80 −0 updated 01/07/19, 09:21

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1621

  1. Anja Leichsenring uploaded patch set 1 11/09/18, 11:15

  2. Anja Leichsenring commented on patch set 1 CR -2 11/09/18, 11:16

    this originated here https://review.typo3.org/c/58869/ and was reverted here https://review.typo3.org/c/58878 and now repushed to wait for v10.
  3. Anja Leichsenring rebased onto patch set 2 11/09/18, 11:19

  4. TYPO3com voted on patch set 1 V +1 11/09/18, 11:33 Completed build in 13m 40s on Fri, 9 Nov, 12:33 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30108

  5. TYPO3com voted on patch set 2 V +1 11/09/18, 11:36 Completed build in 16m 52s on Fri, 9 Nov, 12:36 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30109

  6. Anja Leichsenring rebased onto patch set 3 12/22/18, 17:20

  7. Anja Leichsenring voted on patch set 3 CR 0 12/22/18, 17:20

  8. TYPO3com voted on patch set 3 V +1 12/22/18, 17:32 Completed build in 12m 07s on Sat, 22 Dec, 06:32 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31104

  9. Georg Ringer commented on patch set 3 V +1 CR +1 01/01/19, 19:13

    would still love to get that in 9.5 as well
  10. Andreas Wolf voted on patch set 3 CR +2 01/03/19, 08:52

  11. Guido Schmechel commented on patch set 3 CR +1 01/04/19, 11:56

    +1 for 9.5 Release
  12. Benni Mack commented on patch set 4 01/04/19, 17:58

    Published edit on patch set 3.
  13. TYPO3com voted on patch set 4 V -1 01/04/19, 18:08 Completed build in 10m 05s on Fri, 4 Jan, 07:08 PM Test Summary: 47837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31203

  14. Andreas Kienast commented on patch set 4 01/04/19, 18:11

    Bamboo whines: "missing FullyScanned / PartiallyScanned / NotScanned tag"
  15. Benni Mack commented on patch set 5 01/04/19, 20:36

    Published edit on patch set 4.
  16. TYPO3com voted on patch set 5 V +1 01/04/19, 21:12 Completed build in 1h 05m 39s on Fri, 4 Jan, 10:12 PM Test Summary: 47789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31217

  17. Georg Ringer voted on patch set 5 V +1 CR +1 01/07/19, 08:36

  18. Andreas Kienast voted on patch set 5 CR +1 01/07/19, 08:58

  19. Benni Mack voted on patch set 5 V +2 CR +2 01/07/19, 09:21

  20. Benni Mack merged patch set 6 01/07/19, 09:21

  21. Benni Mack commented on patch set 6 01/07/19, 09:21

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit e69059655aa09fb8fec1439ec4b5f4f073655270