58887[TASK] Move FieldControl/EditPopup handling to module
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Susi Moog +1
- Helmut Hummel +1
- Benni Mack +1
-
Verified V +2
- Anja Leichsenring +2
- Susi Moog +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1722
-
Andreas Kienast uploaded patch set 1 11/11/18, 23:02
-
Andreas Kienast uploaded patch set 2 11/11/18, 23:05
-
TYPO3com voted on patch set 1 V +1 11/11/18, 23:14 Completed build in 12m 30s on Mon, 12 Nov, 12:14 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30125
-
TYPO3com voted on patch set 2 V +1 11/11/18, 23:17 Completed build in 11m 45s on Mon, 12 Nov, 12:17 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30126
-
Andreas Kienast uploaded patch set 3 11/13/18, 16:40
-
TYPO3com voted on patch set 3 V +1 11/13/18, 16:52 Completed build in 11m 58s on Tue, 13 Nov, 05:52 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30132
-
Andreas Kienast uploaded patch set 4 11/18/18, 15:16
-
Andreas Kienast commented on patch set 4 11/18/18, 15:17
Switched back to jQuery.ready() with PS4 for now -
TYPO3com voted on patch set 4 V +1 11/18/18, 15:28 Completed build in 11m 35s on Sun, 18 Nov, 04:28 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30187
-
Oliver Hader commented on patch set 4 11/19/18, 09:04
EditPopup.ts:20properties readonly?EditPopup.ts:24What was the reason for using $.ready? -
Andreas Kienast commented on patch set 4 11/19/18, 09:06
EditPopup.ts:20ReplyIn TypeScript we did a clear separation of protected and private. Since this property is used in this class only, it's private here.EditPopup.ts:24ReplyThe module might be loaded before the whole DOM is ready, which would let the following code fail. -
Oliver Hader commented on patch set 4 11/19/18, 09:11
EditPopup.ts:20ReplySure, I was referring to `readonly`EditPopup.ts:52HTMLSelectElement .selectedOptions directly? -
Oliver Hader commented on patch set 4 11/19/18, 09:13
EditPopup.ts:20Reply... which maybe is not possible when using in a callback -
Andreas Kienast commented on patch set 4 11/19/18, 09:31
EditPopup.ts:20ReplyAh, I misread your remark, sorry. IIRC readonly should still work as the property is still set in the constructor.EditPopup.ts:52ReplyIt's worth a try -
Andreas Kienast commented on patch set 4 11/19/18, 09:34
EditPopup.ts:20ReplyScrew that -
Andreas Kienast uploaded patch set 5 11/19/18, 09:48
-
TYPO3com voted on patch set 5 V +1 11/19/18, 09:58 Completed build in 10m 21s on Mon, 19 Nov, 10:58 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30198
-
Helmut Hummel voted on patch set 5 CR +1 12/06/18, 15:16
-
Benni Mack voted on patch set 5 V +1 CR +1 01/30/19, 05:31
-
Susi Moog voted on patch set 5 V +1 CR +1 02/01/19, 16:34
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 02/01/19, 16:35
-
Anja Leichsenring merged patch set 6 02/01/19, 16:35