Review main Merged

58887[TASK] Move FieldControl/EditPopup handling to module

Andreas Kienast CR +2 V +2 Normal +86 −27 updated 02/01/19, 16:35

Commit message

The FieldControl `EditPopup` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Susi Moog +1
    • Helmut Hummel +1
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1722

  1. Andreas Kienast uploaded patch set 1 11/11/18, 23:02

  2. Andreas Kienast uploaded patch set 2 11/11/18, 23:05

  3. TYPO3com voted on patch set 1 V +1 11/11/18, 23:14 Completed build in 12m 30s on Mon, 12 Nov, 12:14 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30125

  4. TYPO3com voted on patch set 2 V +1 11/11/18, 23:17 Completed build in 11m 45s on Mon, 12 Nov, 12:17 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30126

  5. Andreas Kienast uploaded patch set 3 11/13/18, 16:40

  6. TYPO3com voted on patch set 3 V +1 11/13/18, 16:52 Completed build in 11m 58s on Tue, 13 Nov, 05:52 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30132

  7. Andreas Kienast uploaded patch set 4 11/18/18, 15:16

  8. Andreas Kienast commented on patch set 4 11/18/18, 15:17

    Switched back to jQuery.ready() with PS4 for now
  9. TYPO3com voted on patch set 4 V +1 11/18/18, 15:28 Completed build in 11m 35s on Sun, 18 Nov, 04:28 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30187

  10. Oliver Hader commented on patch set 4 11/19/18, 09:04

    EditPopup.ts:20

    properties readonly?

    EditPopup.ts:24

    What was the reason for using $.ready?
  11. Andreas Kienast commented on patch set 4 11/19/18, 09:06

    EditPopup.ts:20 Reply

    In TypeScript we did a clear separation of protected and private. Since this property is used in this class only, it's private here.

    EditPopup.ts:24 Reply

    The module might be loaded before the whole DOM is ready, which would let the following code fail.
  12. Oliver Hader commented on patch set 4 11/19/18, 09:11

    EditPopup.ts:20 Reply

    Sure, I was referring to `readonly`

    EditPopup.ts:52

    HTMLSelectElement .selectedOptions directly?
  13. Oliver Hader commented on patch set 4 11/19/18, 09:13

    EditPopup.ts:20 Reply

    ... which maybe is not possible when using in a callback
  14. Andreas Kienast commented on patch set 4 11/19/18, 09:31

    EditPopup.ts:20 Reply

    Ah, I misread your remark, sorry. IIRC readonly should still work as the property is still set in the constructor.

    EditPopup.ts:52 Reply

    It's worth a try
  15. Andreas Kienast commented on patch set 4 11/19/18, 09:34

    EditPopup.ts:20 Reply

    Screw that
  16. Andreas Kienast uploaded patch set 5 11/19/18, 09:48

  17. TYPO3com voted on patch set 5 V +1 11/19/18, 09:58 Completed build in 10m 21s on Mon, 19 Nov, 10:58 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30198

  18. Helmut Hummel voted on patch set 5 CR +1 12/06/18, 15:16

  19. Benni Mack voted on patch set 5 V +1 CR +1 01/30/19, 05:31

  20. Susi Moog voted on patch set 5 V +1 CR +1 02/01/19, 16:34

  21. Anja Leichsenring voted on patch set 5 V +2 CR +2 02/01/19, 16:35

  22. Anja Leichsenring merged patch set 6 02/01/19, 16:35