Review main Merged

58897[BUGFIX] Cast PSR-7 Uri object to string in preview links

Achim Fritz CR +2 V +2 Easy +1 −1 updated 11/14/18, 19:55

Commit message

When generating the workspace preview links, the Uri
object needs to be case to string.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2
    • Benni Mack +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Achim Fritz uploaded patch set 1 11/14/18, 18:07

  2. TYPO3com voted on patch set 1 V +1 11/14/18, 18:18 Completed build in 10m 22s on Wed, 14 Nov, 07:18 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30143

  3. Benni Mack updated the commit message in patch set 2 11/14/18, 19:43

  4. Oliver Hader voted on patch set 2 V +1 CR +1 11/14/18, 19:44

  5. TYPO3com voted on patch set 2 V +1 11/14/18, 19:54 Completed build in 11m 31s on Wed, 14 Nov, 08:54 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30144

  6. Benni Mack voted on patch set 2 V +2 CR +2 11/14/18, 19:55

  7. Benni Mack merged patch set 3 11/14/18, 19:55