Review main Merged

58899[BUGFIX] CSS selector in extension configuration modal too specific

Jonas Eberle CR +2 V +2 Easy +4 −6 updated 11/19/18, 07:54

Commit message

The .typo3-install class is not present in the current modal. This
re-introduces the margin above the "save" button.

Review

  • Code review CR +2
    • Benni Mack +2
    • Riccardo De Contardi +1
  • Verified V +2
    • Benni Mack +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Jonas Eberle uploaded patch set 1 11/15/18, 15:21

  2. Jonas Eberle updated the commit message in patch set 2 11/15/18, 15:32

  3. TYPO3com voted on patch set 1 V +1 11/15/18, 15:32 Completed build in 10m 27s on Thu, 15 Nov, 04:32 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30153

  4. Jonas Eberle commented on patch set 2 11/15/18, 15:32

    "typo" in commit message
  5. TYPO3com voted on patch set 2 V +1 11/15/18, 15:42 Completed build in 10m 26s on Thu, 15 Nov, 04:42 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30154

  6. Jonas Eberle updated the commit message in patch set 3 11/15/18, 16:41

  7. TYPO3com voted on patch set 3 V +1 11/15/18, 16:52 Completed build in 10m 49s on Thu, 15 Nov, 05:52 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30155

  8. Riccardo De Contardi voted on patch set 3 V +1 CR +1 11/18/18, 17:19

  9. Benni Mack voted on patch set 3 V +2 CR +2 11/19/18, 07:54

  10. Benni Mack merged patch set 4 11/19/18, 07:54