Review main Merged

58900[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive

Wolfgang Klinger CR +2 V +2 Easy +38 −4 updated 11/19/18, 10:29

Commit message

Prevent an implicit type cast to string through strip_tags.
Ignore any scalar values other than string,
but preserve the possibility of an object's __toString conversion.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +2
    • Mathias Brodala +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1724

  1. Wolfgang Klinger uploaded patch set 1 11/15/18, 16:47

  2. Oliver Klee commented on patch set 1 11/15/18, 16:49

    Can we cover this with tests?
  3. TYPO3com voted on patch set 1 V +1 11/15/18, 16:55 Completed build in 08m 36s on Thu, 15 Nov, 05:55 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30156

  4. Wolfgang Klinger uploaded patch set 2 11/16/18, 09:13

  5. TYPO3com voted on patch set 2 V -1 11/16/18, 09:14 Completed build in 14s on Fri, 16 Nov, 10:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30160

  6. Wolfgang Klinger uploaded patch set 3 11/16/18, 09:31

  7. TYPO3com voted on patch set 3 V +1 11/16/18, 09:41 Completed build in 09m 55s on Fri, 16 Nov, 10:41 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30161

  8. Mathias Brodala commented on patch set 4 11/16/18, 10:11

    Published edit on patch set 3.
  9. TYPO3com voted on patch set 4 V -1 11/16/18, 10:11 Completed build in 13s on Fri, 16 Nov, 11:11 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30163

  10. Mathias Brodala commented on patch set 4 11/16/18, 10:11

    Added safeguard to not process objects without __toString().
  11. Mathias Brodala commented on patch set 5 11/16/18, 10:13

    Published edit on patch set 4.
  12. TYPO3com voted on patch set 5 V +1 11/16/18, 10:24 Completed build in 10m 56s on Fri, 16 Nov, 11:24 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30164

  13. Mathias Brodala voted on patch set 5 CR +1 11/16/18, 10:28

  14. Wolfgang Klinger uploaded patch set 6 11/16/18, 11:31

  15. TYPO3com voted on patch set 6 V +1 11/16/18, 11:40 Completed build in 09m 27s on Fri, 16 Nov, 12:40 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30169

  16. Mathias Brodala commented on patch set 6 11/16/18, 11:42

    We don't have a decision on prefixing function names but from my POV there is no benefit, especially not speed. So I'd prefer to leave them off.
  17. Wolfgang Klinger uploaded patch set 7 11/16/18, 11:44

  18. TYPO3com voted on patch set 7 V +1 11/16/18, 11:54 Completed build in 09m 29s on Fri, 16 Nov, 12:54 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30170

  19. Mathias Brodala voted on patch set 7 CR +1 11/16/18, 11:59

  20. Benni Mack voted on patch set 7 CR +2 11/19/18, 09:09

  21. Benni Mack voted on patch set 7 V +1 11/19/18, 10:27

  22. Georg Ringer voted on patch set 7 V +2 CR +2 11/19/18, 10:29

  23. Georg Ringer merged patch set 8 11/19/18, 10:29

  24. Georg Ringer commented on patch set 8 11/19/18, 10:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 48d3b8c48a81c3508049a888535e8041f172e601