58900[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Benni Mack +2
- Mathias Brodala +1
-
Verified V +2
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1724
-
Wolfgang Klinger uploaded patch set 1 11/15/18, 16:47
-
Oliver Klee commented on patch set 1 11/15/18, 16:49
Can we cover this with tests? -
TYPO3com voted on patch set 1 V +1 11/15/18, 16:55 Completed build in 08m 36s on Thu, 15 Nov, 05:55 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30156
-
Wolfgang Klinger uploaded patch set 2 11/16/18, 09:13
-
TYPO3com voted on patch set 2 V -1 11/16/18, 09:14 Completed build in 14s on Fri, 16 Nov, 10:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30160
-
Wolfgang Klinger uploaded patch set 3 11/16/18, 09:31
-
TYPO3com voted on patch set 3 V +1 11/16/18, 09:41 Completed build in 09m 55s on Fri, 16 Nov, 10:41 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30161
-
Mathias Brodala commented on patch set 4 11/16/18, 10:11
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V -1 11/16/18, 10:11 Completed build in 13s on Fri, 16 Nov, 11:11 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30163
-
Mathias Brodala commented on patch set 4 11/16/18, 10:11
Added safeguard to not process objects without __toString(). -
Mathias Brodala commented on patch set 5 11/16/18, 10:13
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 11/16/18, 10:24 Completed build in 10m 56s on Fri, 16 Nov, 11:24 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30164
-
Mathias Brodala voted on patch set 5 CR +1 11/16/18, 10:28
-
Wolfgang Klinger uploaded patch set 6 11/16/18, 11:31
-
TYPO3com voted on patch set 6 V +1 11/16/18, 11:40 Completed build in 09m 27s on Fri, 16 Nov, 12:40 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30169
-
Mathias Brodala commented on patch set 6 11/16/18, 11:42
We don't have a decision on prefixing function names but from my POV there is no benefit, especially not speed. So I'd prefer to leave them off. -
Wolfgang Klinger uploaded patch set 7 11/16/18, 11:44
-
TYPO3com voted on patch set 7 V +1 11/16/18, 11:54 Completed build in 09m 29s on Fri, 16 Nov, 12:54 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30170
-
Mathias Brodala voted on patch set 7 CR +1 11/16/18, 11:59
-
Benni Mack voted on patch set 7 CR +2 11/19/18, 09:09
-
Benni Mack voted on patch set 7 V +1 11/19/18, 10:27
-
Georg Ringer voted on patch set 7 V +2 CR +2 11/19/18, 10:29
-
Georg Ringer merged patch set 8 11/19/18, 10:29
-
Georg Ringer commented on patch set 8 11/19/18, 10:29
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 48d3b8c48a81c3508049a888535e8041f172e601