Review main Merged

58901[BUGFIX] Add RootPage to Slug Candidates

Achim Fritz CR +2 V +2 Easy +2 −0 updated 11/16/18, 09:57

Commit message

The slug candidates resolving now takes "/" into account,
allowing to find the root page as well. This way, the PageRouter
applies Route Enhancers to the root page as well,
so segments like "/my-news-plugin/" also applies to
"/".

Review

  • Code review CR +2
    • Benni Mack +2
    • Steffen Dietrich +1
  • Verified V +2
    • Benni Mack +2
    • Steffen Dietrich +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Achim Fritz uploaded patch set 1 11/15/18, 18:57

  2. TYPO3com voted on patch set 1 V +1 11/15/18, 19:07 Completed build in 10m 00s on Thu, 15 Nov, 08:07 PM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30157

  3. Benni Mack updated the commit message in patch set 2 11/16/18, 08:50

  4. Benni Mack voted on patch set 2 V +1 CR +1 11/16/18, 08:50

  5. TYPO3com voted on patch set 2 V +1 11/16/18, 09:01 Completed build in 10m 51s on Fri, 16 Nov, 10:01 AM Test Summary: 48464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30158

  6. Steffen Dietrich voted on patch set 2 V +1 CR +1 11/16/18, 09:41

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/16/18, 09:57

  8. Benni Mack merged patch set 3 11/16/18, 09:57