Review main Merged

58907[TASK] Check number of file extensions

Guido Schmechel CR +2 V +2 Normal +49 −45 updated 11/19/18, 08:34

Commit message

Show the add media and text form only if at least
one file extension exists.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Josef Glatz +1
    • Riccardo De Contardi +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Guido Schmechel uploaded patch set 1 11/16/18, 21:47

  2. TYPO3com voted on patch set 1 V +1 11/16/18, 21:59 Completed build in 11m 05s on Fri, 16 Nov, 10:59 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30175

  3. Wolfgang Klinger voted on patch set 1 CR +1 11/17/18, 09:22

  4. Josef Glatz voted on patch set 1 CR +1 11/17/18, 10:29

  5. Oliver Klee commented on patch set 1 11/18/18, 15:10

    CreateFolder.html:42

    Should we indent the HTML within the condition?
  6. Andreas Kienast uploaded patch set 2 11/18/18, 15:15

  7. Oliver Klee voted on patch set 2 CR +1 11/18/18, 15:18

  8. TYPO3com voted on patch set 2 V +1 11/18/18, 15:27 Completed build in 11m 58s on Sun, 18 Nov, 04:27 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30186

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 11/18/18, 15:37

  10. Riccardo De Contardi commented on patch set 2 V +1 11/18/18, 16:00

    Tried on latest master with the expressions `\.[^\.]*$` and `((\.[^.\s]+)+)$`on `[BE][fileDenyPattern]`
  11. Josef Glatz voted on patch set 2 V +1 CR +1 11/18/18, 16:24

  12. Benni Mack voted on patch set 2 V +2 CR +2 11/19/18, 08:34

  13. Benni Mack merged patch set 3 11/19/18, 08:34