58908[FEATURE] Support nomodule for JavaScript includes
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Page/PageRenderer.php+16 −6
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-86759-SupportNomoduleAttributeForJavaScriptIncludes.rstnew+22 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+113 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+21 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+8 −4
Review log 3143
Show 1318 earlier messages
-
Guido Schmechel uploaded patch set 1 11/16/18, 22:46
-
Guido Schmechel uploaded patch set 2 11/16/18, 22:49
-
TYPO3com voted on patch set 1 V +1 11/16/18, 22:58 Completed build in 11m 30s on Fri, 16 Nov, 11:58 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30176
-
TYPO3com voted on patch set 2 V +1 11/16/18, 23:01 Completed build in 12m 19s on Sat, 17 Nov, 12:01 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30177
-
Riccardo De Contardi commented on patch set 2 11/16/18, 23:32
when you have more than one file for example in the array `includeJSLibs` and `config.concatenateJS = 1` the result is 1 merged file, without the nomodule attribute. I guess it's correct, but can you confirm me that is it the intended behavior? Maybe it should be mentioned in the rst file -
Riccardo De Contardi commented on patch set 2 11/16/18, 23:34
I forgot to mention: more that one file in includeJSLibs, but ONLY ONE with file.nomodule = 1 :) sorry -
Guido Schmechel commented on patch set 2 V -1 CR -1 11/17/18, 08:17
Good point. nomodule Files shouldn't merged because they loose this info and are available for all cases. -
Riccardo De Contardi commented on patch set 2 11/17/18, 10:54
of course `excludeFromConcatenation` could be used :) I think that sooner or later it could be useful to introduce the concept of "group" to specify that the files that share the same group must be concatenated altogether -
Guido Schmechel uploaded patch set 3 11/17/18, 11:09
-
Guido Schmechel commented on patch set 3 V -1 CR -1 11/17/18, 11:11
I agree. But i think we offer the shortest "config" way and so nomodule is automatically exluded from concatenation :-) -1 because of feature freeze -
TYPO3com voted on patch set 3 V -1 11/17/18, 11:19 Completed build in 09m 06s on Sat, 17 Nov, 12:19 PM Test Summary: 28 of 48892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30181
-
Guido Schmechel uploaded patch set 4 11/17/18, 11:25
-
TYPO3com voted on patch set 4 V +1 11/17/18, 11:36 Completed build in 10m 32s on Sat, 17 Nov, 12:36 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30182
-
Mathias Brodala commented on patch set 5 11/19/18, 08:30
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 11/19/18, 08:42 Completed build in 12m 17s on Mon, 19 Nov, 09:42 AM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30195
-
Riccardo De Contardi commented on patch set 5 11/19/18, 08:44
Same logic should be applied to the "defer" attribute? -
Frank Nägler commented on patch set 5 05/31/19, 13:56
no activity on this patch since months, is anyone still working on it? @Guido, would you do a rebase and resolve the merge conflicts? I think this a nice patch we could add to core. -
Guido Schmechel commented on patch set 5 05/31/19, 14:50
I'm not so fit in Rebase. Maybe I need help there ;-)
-
Oliver Klee commented on patch set 5 05/31/19, 17:28
Can we please have tests for this new feature? -
Guido Schmechel uploaded patch set 6 05/31/19, 19:26
-
TYPO3com voted on patch set 6 V +1 05/31/19, 19:39 Completed build in 13m 22s on Fri, 31 May, 09:39 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34125
-
Guido Schmechel commented on patch set 6 CR -1 05/31/19, 19:44
Will have look -
Guido Schmechel commented on patch set 6 05/31/19, 19:55
> Patch Set 5: > > Same logic should be applied to the "defer" attribute? That would have to be a separate patch. Would also be a "breaking change". -
Guido Schmechel uploaded patch set 7 06/01/19, 18:15
-
TYPO3com voted on patch set 7 V -1 06/01/19, 18:15 Completed build in 13s on Sat, 1 Jun, 08:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34126
-
Guido Schmechel uploaded patch set 8 06/01/19, 18:18
-
TYPO3com voted on patch set 8 V -1 06/01/19, 18:31 Completed build in 13m 29s on Sat, 1 Jun, 08:31 PM Test Summary: 3 of 46820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34127
-
Guido Schmechel uploaded patch set 9 06/01/19, 18:36
-
TYPO3com voted on patch set 9 V +1 06/01/19, 18:49 Completed build in 12m 26s on Sat, 1 Jun, 08:49 PM Test Summary: 46481 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34128
-
Guido Schmechel uploaded patch set 10 06/01/19, 21:28
-
TYPO3com voted on patch set 10 V +1 06/01/19, 21:43 Completed build in 14m 41s on Sat, 1 Jun, 11:43 PM Test Summary: 46485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34131
-
Guido Schmechel commented on patch set 10 06/01/19, 21:49
I hope the tests are good enough. But they should cover what has been added. -
Tobi Kretschmann voted on patch set 10 CR +1 07/10/19, 10:01
-
Steffen Frese voted on patch set 10 CR +1 07/10/19, 11:49
-
Tobi Kretschmann voted on patch set 10 V +2 CR +2 07/11/19, 14:12
-
Guido Schmechel uploaded patch set 11 07/28/19, 17:51
-
TYPO3com voted on patch set 11 V +1 07/28/19, 18:02 Completed build in 10m 34s on Sun, 28 Jul, 08:02 PM Test Summary: 47167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35350
-
Andreas Kienast uploaded patch set 12 10/26/19, 07:29
-
TYPO3com voted on patch set 12 V +1 10/26/19, 07:52 Completed build in 20m 26s on Sat, 26 Oct, 07:52 AM Test Summary: 48066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37759
-
Daniel Goerz voted on patch set 12 V +1 CR +1 11/09/19, 12:37
-
Susi Moog voted on patch set 12 CR +1 11/09/19, 12:48
-
Susi Moog voted on patch set 12 V +2 CR +2 11/09/19, 12:57
-
Susi Moog merged patch set 13 11/09/19, 12:57