Review main Abandoned

58909[BUGFIX] Reimplement uploadFieldsInTopOfEB

Guido Schmechel CR 0 V 0 Easy +20 −3 updated 10/25/19, 18:58

Commit message

Displaying the uploadForm on top is available again.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1520

  1. Guido Schmechel uploaded patch set 1 11/17/18, 15:01

  2. TYPO3com voted on patch set 1 V -1 11/17/18, 15:11 Completed build in 09m 27s on Sat, 17 Nov, 04:11 PM Test Summary: 4 of 48892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30184

  3. Guido Schmechel uploaded patch set 2 11/17/18, 15:14

  4. TYPO3com voted on patch set 2 V +1 11/17/18, 15:24 Completed build in 09m 57s on Sat, 17 Nov, 04:24 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30185

  5. Benni Mack commented on patch set 2 11/19/18, 09:08

    Hey, this kind of contradicts this one: https://review.typo3.org/#/c/58872/ So, adding it to FileBrowser is probably only one place where this needs to be re-added...
  6. Guido Schmechel voted on patch set 2 V -1 CR -1 11/19/18, 09:21

  7. Guido Schmechel uploaded patch set 3 11/27/18, 20:12

  8. TYPO3com voted on patch set 3 V +1 11/27/18, 20:35 Completed build in 20m 07s on Tue, 27 Nov, 09:35 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30318

  9. Benni Mack commented on patch set 3 12/12/18, 06:35

    back in v7 this was also part of FileLinkHandler.php, should it be implemented there as well?
  10. Guido Schmechel uploaded patch set 4 12/15/18, 15:33

  11. TYPO3com voted on patch set 4 V +1 12/15/18, 15:44 Completed build in 10m 46s on Sat, 15 Dec, 04:44 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30732

  12. Guido Schmechel commented on patch set 4 12/15/18, 16:17

    Testing: - Add userTsConfig (Module Backend Users) - Add a Text/Media Element - Add an image and check position of uploadform in the filelist - Add a link in the bodytext. Click on tab "File" and check position of uploadform in the filelist
  13. Guido Schmechel uploaded patch set 5 12/15/18, 17:44

  14. TYPO3com voted on patch set 5 V +1 12/15/18, 17:55 Completed build in 11m 11s on Sat, 15 Dec, 06:55 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30733

  15. Stefanos Karasavvidis commented on patch set 5 V -1 01/07/19, 13:59

    Although the patch does what it is supposed to do, the overall user experience is still problematic. First of all, the "create new folder" form should stay together with the "upload file" form. Now it gets separated if uploadFieldsInTopOfEB is set. Moreover, the "Upload files" form should get more compact (on desktops, there is enough space to get all elements into one line). And the 3 forms "Upload files", "Add new media asset" and "create new folder" should be separated more clearly from each other. I can think of a new tab for these 3 forms, or an initially hidden area that slides down to reveal the 3 forms.
  16. Guido Schmechel commented on patch set 5 01/07/19, 14:09

    Good catch. What do you think about two steps? First patch reimplement the old logic. So we can use it in 9.x as well as in earlier TYPO3 versions. Second patch, is a follow up patch which introduces your ux optimizations.
  17. Stefanos Karasavvidis commented on patch set 5 01/08/19, 07:57

    this would mean to reintroduce a flawed behavior. Why was this option removed in the first place?
  18. Guido Schmechel commented on patch set 5 01/08/19, 09:14

    > Patch Set 5: > > this would mean to reintroduce a flawed behavior. Why was this option removed in the first place? I think it was overlooked during refactoring because the code was hidden for output in the PHP class. There are matching tickets: https://forge.typo3.org/issues/86885 and https://forge.typo3.org/issues/80463
  19. Benjamin Kott commented on patch set 5 V -1 CR -1 10/25/19, 18:56

    It is not planned to reintroduce this feature, this is part of streamlining the backend.
  20. Susi Moog abandoned the change 10/25/19, 18:58

    As Benji has the overview on all things UX I'm going to abandon this one for now. Linkbrowser usability in general can be revisited as a whole at a later point in time.