Review main Merged

58910[BUGFIX] Remove unused `fieldChangeFunc` in GroupElement

Andreas Kienast CR +2 V +2 Easy +0 −7 updated 11/19/18, 12:48

Commit message

The class GroupElement defines a `fieldChangeFunc` which is unused in
this context. Since this never caused an issue, it's assumed to be save
to remove the change handler.

This allows further cleanup in the FormEngine JavaScript land, e.g.
deprecating `setFormValueManipulate()`.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 11/18/18, 19:47

  2. TYPO3com voted on patch set 1 V +1 11/18/18, 19:58 Completed build in 10m 37s on Sun, 18 Nov, 08:58 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30189

  3. Wouter Wolters voted on patch set 1 CR +1 11/19/18, 08:44

  4. Georg Ringer voted on patch set 1 V +1 CR +1 11/19/18, 11:39

  5. Benni Mack voted on patch set 1 V +2 CR +2 11/19/18, 12:48

  6. Benni Mack merged patch set 2 11/19/18, 12:48