Review TYPO3_8-7 Merged

58911[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter

Benni Mack CR +2 V +2 Easy +1 −1 updated 11/19/18, 08:11

Commit message

The return value of the hmac check is a string and must be casted to
an integer as the method using the value requires an integer.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 11/19/18, 07:52

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/19/18, 08:11 Completed build in 18m 55s on Mon, 19 Nov, 09:11 AM Test Summary: 79278 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3197

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/19/18, 08:11

  4. Benni Mack merged patch set 2 11/19/18, 08:11