Review main Abandoned

58917[BUGFIX] Optimize flushByTags() by using a loop over tags

TYPO3com CR 0 V 0 Normal +44 −44 updated 10/14/21, 18:54

Commit message

A loop over tags performs better than a single large DELETE with IN().

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1624

  1. TYPO3com uploaded patch set 1 11/20/18, 10:50

  2. TYPO3com voted on patch set 1 V -1 11/20/18, 10:50 Completed build in 10s on Tue, 20 Nov, 11:50 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30210

  3. Wolfgang Klinger uploaded patch set 2 11/24/18, 16:43

  4. TYPO3com voted on patch set 2 V +1 11/24/18, 16:53 Completed build in 10m 25s on Sat, 24 Nov, 05:53 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30266

  5. Jörg Velletti commented on patch set 2 V +1 CR +1 11/26/18, 09:17

    The new code after patch set is also working in my DEV Version of 8.7.19
  6. Benni Mack updated the commit message in patch set 3 12/14/18, 10:12

  7. Benni Mack commented on patch set 3 12/14/18, 10:12

    Updated the releases line, please re-apply your votes
  8. Wolfgang Klinger voted on patch set 3 V +1 CR +1 03/12/19, 06:56

  9. TYPO3com voted on patch set 3 V +1 03/12/19, 20:10 Completed build in 10m 29s on Tue, 12 Mar, 09:10 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32681

  10. Mona Muzaffar commented on patch set 3 CR +1 04/05/19, 15:01

    Typo3DatabaseBackend.php:263 Unresolved

    I think this comment needs to be adjusted, since no longer a bulk query is perfomed? And instead of duplicating the additional comment : "// VERY simple quoting of ...", I would optimize the PHPdoc comment in general and maybe add this information there. But that is just nitpicking
  11. Steffen Frese voted on patch set 3 CR +1 04/08/19, 07:23

  12. Jörg Bösche uploaded patch set 4 04/08/19, 07:54

  13. TYPO3com voted on patch set 4 V -1 04/08/19, 07:54 Completed build in 11s on Mon, 8 Apr, 09:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33104

  14. Jörg Bösche uploaded patch set 5 04/08/19, 07:56

  15. TYPO3com voted on patch set 5 V +1 04/08/19, 08:10 Completed build in 14m 24s on Mon, 8 Apr, 10:10 AM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33105

  16. Steffen Frese voted on patch set 5 CR +1 04/08/19, 08:28

  17. Frank Nägler commented on patch set 5 CR -1 05/31/19, 11:03

    Typo3DatabaseBackend.php:284 Unresolved

    please use the quote function of the $connection

    Typo3DatabaseBackend.php:302 Unresolved

    use createNamedParameter here
  18. Andreas Kienast uploaded patch set 6 10/14/19, 07:19

  19. Andreas Kienast uploaded patch set 7 10/14/19, 07:21

  20. TYPO3com voted on patch set 6 V -1 10/14/19, 07:31 Completed build in 11m 19s on Mon, 14 Oct, 07:31 AM Test Summary: 3 of 48089 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37295

  21. TYPO3com voted on patch set 7 V +1 10/14/19, 07:32 Completed build in 10m 48s on Mon, 14 Oct, 07:32 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37296

  22. Benni Mack commented on patch set 7 01/18/20, 15:38

    Typo3DatabaseBackend.php:289 Unresolved

    this sounds like we could use a prepared statement here?
  23. Benni Mack commented on patch set 7 03/04/20, 08:23

    Anyone up for rebasing this change?
  24. Anja Leichsenring abandoned the change 10/14/21, 18:54

    this change made it in, the current core code uses the in function for deletion of tags.