Review main Abandoned

58919[FEATURE] add an alternative regexp_target to sys_redirects

Christoph Kratz CR 0 V 0 Normal +104 −20 updated 08/30/19, 20:05

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1012

  1. Christoph Kratz uploaded patch set 1 11/20/18, 15:34

  2. TYPO3com voted on patch set 1 V -1 11/20/18, 15:34 Completed build in 13s on Tue, 20 Nov, 04:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30213

  3. Mathias Brodala commented on patch set 1 CR -1 11/20/18, 15:49

    Features require a RST documenting the change.
  4. Christoph Kratz uploaded patch set 2 11/21/18, 08:48

  5. TYPO3com voted on patch set 2 V -1 11/21/18, 08:59 Completed build in 10m 30s on Wed, 21 Nov, 09:59 AM Test Summary: 24 of 48896 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30221

  6. Wouter Wolters commented on patch set 2 CR -1 11/21/18, 17:47

    Repeating the question from Mathias: Features require a RST documenting the change. Furthermore we are not branched of yet so 9.5 is not needed in the Releases line
  7. Frank Nägler commented on patch set 2 05/31/19, 13:57

    no activity on this patch since months, is anyone still working on it?
  8. Wouter Wolters wrote 06/04/19, 13:15

    Removed Code-Review-1 by Wouter Wolters <typo3@wouterwolters.nl>
  9. Wouter Wolters wrote 06/04/19, 13:15

    Removed reviewer Wouter Wolters.
  10. Daniel Goerz commented on patch set 2 V -1 CR -1 06/29/19, 12:15

    Unresolved

    Issue dos not exist

    Unresolved

    A new Feature can only be merged to master

    RedirectService.php:178 Unresolved

    Please use the Uri Object for this like it is done below.

    RedirectService.php:185 Unresolved

    Do not use HttpUtility::redirect in the Redirect Middleware. The whole Point of this middleware is to return a RedirectResponse after a redirect match was found.
  11. Daniel Goerz commented on patch set 2 06/29/19, 12:19

    As there was no response to Franks comment, please use my feedback to provide a more suitable approach to this Feature. Otherwise I will abandon the patch in a few weeks to reduce bloat of the review queue. Of course a new patch can be pushed at any time.
  12. Daniel Goerz abandoned the change 08/30/19, 20:05

    Abandoned due to lack of activity